Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin cryptography package in azure-cli-core #19635

Closed
ivanst0 opened this issue Sep 21, 2021 · 2 comments · Fixed by #19639
Closed

Unpin cryptography package in azure-cli-core #19635

ivanst0 opened this issue Sep 21, 2021 · 2 comments · Fixed by #19639
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Packaging
Milestone

Comments

@ivanst0
Copy link

ivanst0 commented Sep 21, 2021

Would it be possible to unpin the cryptography dependency by changing
cryptography>=3.2,<3.4
to
cryptography~=3.2
in /src/azure-cli-core/setup.py?

This change won't affect great majority of Azure CLI users (who are using prebuilt packages with cryptography==3.3.2).

The users who are still using an older OS which doesn't have rust support (e.g. Alpine) can still apply a simple workaround (installing cryptography==3.3.2 before installing Azure-CLI).
If it is important that install.py works on those platforms without any additional fixes, this script can be modified to install cryptography==3.3.2 before installing azure-cli.

@ghost ghost added needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Sep 21, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Sep 21, 2021
@yonzhan yonzhan removed the question The issue doesn't require a change to the product in order to be resolved. Most issues start as that label Sep 21, 2021
@yonzhan yonzhan added this to the Backlog milestone Sep 21, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 21, 2021

@jiasli for awareness

@jiasli
Copy link
Member

jiasli commented Sep 22, 2021

The reason an upper bound is set is explained in #15687 (comment).

By following https://cryptography.io/en/latest/installation/#building-cryptography-on-linux, I am now able to install cryptography on Alpine Linux (#19591).

Let me unpin the dependency on cryptography.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Packaging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants