Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Loosen cryptography dependency #19639

Merged
merged 2 commits into from
Sep 28, 2021
Merged

{Packaging} Loosen cryptography dependency #19639

merged 2 commits into from
Sep 28, 2021

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Sep 22, 2021

Description

Reasons why we can loose the cryptography dependency now:

For upper bound

#15687 (comment) set an upper bound for cryptography due to pyca/cryptography#5771.

By following https://cryptography.io/en/latest/installation/#alpine, I am now able to install cryptography 3.4.8 on Alpine Linux (#19591). There is no need to set upper bound now.

For lower bound

Community packagers ask us not to bump the minimum dependency in setup.py as this causes trouble for platforms that doesn't support newer versions of cryptography (#15687 (comment)). By loosing the dependency on cryptography, users or packagers themselves are now responsible for security vulnerabilities in older versions of cryptography.

As we still pin the version in requirements.*.txt, packages distributed by us still contain cryptography which is security-complaint.

src/azure-cli-core/setup.py Outdated Show resolved Hide resolved
@jiasli jiasli changed the title {Packaging} Loose cryptography dependency {Packaging} Loosen cryptography dependency Sep 22, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 22, 2021

Packaging

@yonzhan yonzhan added this to the Sep 2021 (2021-10-12) milestone Sep 22, 2021
@jiasli
Copy link
Member Author

jiasli commented Sep 22, 2021

@glaubitz, I have totally removed the lower bound. Will this suit your need?

@glaubitz
Copy link

Is version 3.0 actually the absolute minimum that you need now? That is, is there functionality that you need that is not part of version 2.8?

@jiasli
Copy link
Member Author

jiasli commented Sep 24, 2021

We don't require >3.0 now. Any version works.

@glaubitz
Copy link

Then either remove the version requirement or use at least 2.8 which is what SLE-12 and SLE-15 are shipping at the moment.

@jiasli
Copy link
Member Author

jiasli commented Sep 24, 2021

Then either remove the version requirement

It is already removed.

https://github.com/Azure/azure-cli/pull/19639/files

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin cryptography package in azure-cli-core
5 participants