appservice: fix slot related bugs #2388
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2388 +/- ##
==========================================
+ Coverage 72.2% 72.24% +0.03%
==========================================
Files 323 323
Lines 18098 18154 +56
Branches 2654 2666 +12
==========================================
+ Hits 13068 13115 +47
- Misses 4206 4209 +3
- Partials 824 830 +6
Continue to review full report at Codecov.
|
|
@yugangw-msft This looks awesome! Any thoughts on whether we could address #2316 as well? Slots feel like a key/compelling feature of web apps, and it would help a lot to reduce the typing needed to use it: |
|
@lostintangent, for #2366 and couple of other related naming issues, are pending review with webapp team, and i will try to post update soon |
|
@yugangw-msft OK cool, thanks so much! This PR looks beautiful. |
| @@ -10,6 +10,9 @@ | |||
|
|
|||
| from ._client_factory import web_client_factory | |||
|
|
|||
| def output_slots_In_table(slots): | |||
There was a problem hiding this comment.
nit: lower case i in method name
| @@ -10,6 +10,9 @@ | |||
|
|
|||
| from ._client_factory import web_client_factory | |||
|
|
|||
| def output_slots_In_table(slots): | |||
| return [{'name': s['name'], 'status': s['state'], 'app service plan': s['appServicePlan']} for s in slots] | |||
There was a problem hiding this comment.
Haven't seen any other table headings with spaces in.
'app service plan' -> 'appServicePlan'?
There was a problem hiding this comment.
Could we actually just call it "Plan"?
There was a problem hiding this comment.
Yep, let us go withplan, i like shorter name and we are already under the context of app service. I used app service plan simply because portal does it, but this is not a very necessary alignment we have to do
Fix #1895: so people can specify that an appsetting shouldn't participate in a swap
Fix #1870: Add a short name alias for the slot parameter
Fix #1868: Help text for creating a deployment slot isn't completely clear
Fix #1867: Deployment slot list doesn't provide the actual "raw" slot name