Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Signalr show" fails with unexpected error when the resource doesn't exist #9904

Closed
rachelvwood opened this issue Jul 10, 2019 · 1 comment · Fixed by #12266
Closed

"Signalr show" fails with unexpected error when the resource doesn't exist #9904

rachelvwood opened this issue Jul 10, 2019 · 1 comment · Fixed by #12266
Labels
needs-triage This is a new issue that needs to be triaged to the appropriate team. Service Attention This issue is responsible by Azure service team.
Milestone

Comments

@rachelvwood
Copy link

Describe the bug

"Signalr show" fails with unexpected error when the signalr service doesn't exist. When the service does exist, "signalr show" works as expected.

Command Name
az signalr show

Errors:

The command failed with an unexpected error. Here is the traceback:


'CommandResultItem' object is not iterable
Traceback (most recent call last):
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-76yvurxi\knack\knack\cli.py", line 212, in invoke
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-76yvurxi\knack\knack\output.py", line 132, in out
  File "C:\Users\VSSADM~1\AppData\Local\Temp\pip-install-76yvurxi\knack\knack\output.py", line 38, in format_json
TypeError: 'CommandResultItem' object is not iterable

To Reproduce:

Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

  • az signalr show --name <nonexistent-signalr-service> --resource-group <existing-resource-group>

Expected Behavior

Printing an error message like "Signalr service doesn't exist"

Environment Summary

Windows-10-10.0.18362-SP0
Python 3.6.6
Shell: powershell.exe

azure-cli 2.0.68

Extensions:
application-insights 0.1.1

Additional Context

@tjprescott tjprescott added Service Attention This issue is responsible by Azure service team. SignalR az signalr Needs Triage labels Jul 10, 2019
@yonzhan yonzhan removed the triage label Sep 2, 2019
@haroldrandom haroldrandom added needs-triage This is a new issue that needs to be triaged to the appropriate team. Service Attention This issue is responsible by Azure service team. Signal R labels Oct 25, 2019
@stan-sz
Copy link
Contributor

stan-sz commented Feb 18, 2020

The fix for this issue seems to be to change the g.command('show',...) in

g.command('show', 'signalr_show', exception_handler=empty_on_404)

to g.show_command('show', ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage This is a new issue that needs to be triaged to the appropriate team. Service Attention This issue is responsible by Azure service team.
Projects
None yet
5 participants