[Network] Add support for setting identity in Application-Gateway #10119

mmyyrroonn · 2019-08-01T09:12:42Z

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.

mmyyrroonn · 2019-08-01T09:14:53Z

ManagedIdentity cannot be created by CLI so I don't add test code. I manually tested the command. Meanwhile, due to the service limitation, I don't expose the add and remove command to the user.

src/azure-cli/azure/cli/command_modules/network/_help.py

Juliehzl · 2019-08-14T07:35:11Z

src/azure-cli/azure/cli/command_modules/network/_help.py

@@ -328,6 +328,26 @@
            -n MyHttpSettings --probe MyNewProbe
 """

+helps['network application-gateway identity'] = """
+type: group
+short-summary: Manage the identity information


Do you need a long summary like vm identity ‘This is required to authenticate and interact with other Azure services using bearer tokens.'?

I need confirm with service team. For know, the identity is used to access the key vault.

src/azure-cli/azure/cli/command_modules/network/_help.py

src/azure-cli/azure/cli/command_modules/network/custom.py

src/azure-cli/azure/cli/command_modules/network/_params.py

Juliehzl · 2019-09-02T08:05:02Z

Can you try to resolve conflicts first?

src/azure-cli/HISTORY.rst

src/azure-cli/azure/cli/command_modules/network/_params.py

Juliehzl · 2019-09-02T08:57:01Z

src/azure-cli/azure/cli/command_modules/network/_params.py

@@ -138,6 +143,7 @@ def load_arguments(self, _):
        c.argument('cert_password', help='The certificate password')
        c.argument('http_settings_port', help='The HTTP settings port.')
        c.argument('servers', ag_servers_type)
+        c.argument('key_vault_secret_id', help="Secret Id of (base-64 encoded unencrypted pfx) 'Secret' or 'Certificate' object stored in Azure KeyVault. You need enable soft delete for keyvault to use this feature.", is_preview=True)


What kind of message does server return when no identity assigned or no access policy set?

identity should be set. The server will check the existence of the identity

src/azure-cli/azure/cli/command_modules/network/_template_builder.py

src/azure-cli/azure/cli/command_modules/network/_validators.py

Juliehzl · 2019-09-03T08:48:07Z

src/azure-cli/azure/cli/command_modules/network/commands.py

@@ -428,6 +428,11 @@ def _make_singular(value):
        g.custom_command('set', 'set_ag_waf_config_2016_09_01', max_api='2016-09-01', supports_no_wait=True)
        g.custom_show_command('show', 'show_ag_waf_config')
        g.custom_command('list-rule-sets', 'list_ag_waf_rule_sets', min_api='2017-03-01', client_factory=cf_application_gateways, table_transformer=transform_waf_rule_sets_table_output)
+
+    with self.command_group('network application-gateway identity', command_type=network_ag_sdk, min_api='2018-12-01') as g:
+        g.custom_command('assign', 'assign_ag_identity', supports_no_wait=True)


Why do you want to make it support --no-wait? It is a long-running operation?

mmyyrroonn requested a review from tjprescott August 1, 2019 09:12

yugangw-msft reviewed Aug 1, 2019

View reviewed changes

src/azure-cli/azure/cli/command_modules/network/_help.py Outdated Show resolved Hide resolved

mmyyrroonn force-pushed the fix-10073-application-gateway-update branch 2 times, most recently from 3a5f6ef to 83f987b Compare August 6, 2019 06:13

mmyyrroonn requested review from yugangw-msft, Juliehzl and zikalino August 7, 2019 14:45

mmyyrroonn force-pushed the fix-10073-application-gateway-update branch from 5a3d4be to 9326987 Compare August 12, 2019 05:56