Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} add perl in docker #12052

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Conversation

fengzhou-msft
Copy link
Member

Fix #12015

@yonzhan yonzhan added this to the S165 milestone Feb 5, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Feb 5, 2020

add to S165.

@haroldrandom
Copy link
Contributor

Why need perl?
As I far as I understand, this issue should install perl by he/she self in his/her Dockerfile, it's not a azure-cli requirement.

@fengzhou-msft
Copy link
Member Author

fengzhou-msft commented Feb 5, 2020

Why need perl?
As I far as I understand, this issue should install perl by he/she self in his/her Dockerfile, it's not a azure-cli requirement.

The docker doesn't need git either if we just want to run azure-cli.
I guess git was put in the docker for user's convenience. As some git functions rely on perl, we may also put in perl.

@haroldrandom
Copy link
Contributor

Why need perl?
As I far as I understand, this issue should install perl by he/she self in his/her Dockerfile, it's not a azure-cli requirement.

The docker doesn't need git either if we just want to run azure-cli.
I guess git was put in the docker for user's convenience, as some git functions rely on perl. We may also put in perl.

Understood, if that so, I would recommend to put perl ahead of git since it's more fundamental that git, many other softwares rely on it.

@fengzhou-msft fengzhou-msft merged commit 9a7016a into Azure:dev Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"git add --patch" fails due to missing perl package
4 participants