[ACR] Add a new argument '--expose-token' for 'az acr login' #12077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add to S165. |
yugangw-msft
reviewed
Feb 7, 2020
| tenant_suffix=tenant_suffix, | ||
| username=username, | ||
| password=password) | ||
| logger.warning("You can perform manual login with the ouput access token, for example: 'docker login loginServer -u GUID -p accessToken'") |
There was a problem hiding this comment.
I believe the GUID here should be 00...1 always. If yes, let us just use the fixed vaule.
| } | ||
| return token_info | ||
|
|
||
| tips = "You may want to use 'az acr login -n MyRegistry --expose-token' to get an access token, which does not require Docker to be installed." |
There was a problem hiding this comment.
Please use the real registry name instead of MyRegistry so that users can just copy & paste
| from azure.cli.core.util import in_cloud_console | ||
| if in_cloud_console(): | ||
| raise CLIError('This command requires running the docker daemon, which is not supported in Azure Cloud Shell.') | ||
| raise CLIError('This command requires running the docker daemon, which is not supported in Azure Cloud Shell.' + tips) |
There was a problem hiding this comment.
You might need a white space string before the Tips
| logger.warning("You can perform manual login with the ouput access token, for example: 'docker login loginServer -u GUID -p accessToken'") | ||
| token_info = { | ||
| "loginServer" : login_server, | ||
| "GUID" : username, |
There was a problem hiding this comment.
Again username could be None and if yes, the value will be 000...1.
…gistry' with user's real registry name in tips 2.Revise wording 3.Fix trailing whitespaces
yugangw-msft
approved these changes
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9442
Behavior:
[specify --expose-token]
[docker command error]
[help manual]
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.