[Storage] az storage copy: Add parameter --content-type to fix#6466 #12237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an issue with azcopy 10.3 and the content-type cannot work as expected. Let's merge it when azcopy is ready. |
jiasli
reviewed
Feb 18, 2020
| @@ -507,6 +507,8 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem | |||
| c.argument('exclude_path', exclude_path_type) | |||
| c.argument('include_path', include_path_type) | |||
| c.argument('recursive', recursive_type) | |||
| c.argument('content_type', arg_group='Additional Flags', help="Specify content type of the file. " | |||
| "Implies no-guess-mime-type.") | |||
There was a problem hiding this comment.
Maybe we can use imperative mood for alignment? Also, "Implies" isn't very intuitive to me. Possibly "If unspecified, ..."?
There was a problem hiding this comment.
We misunderstood it! 😰 It means if --content-type is given, --no-guess-mime-type is implied.
|
add to S167 |
jiasli
reviewed
Mar 23, 2020
| @@ -557,6 +557,8 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem | |||
| c.argument('exclude_path', exclude_path_type) | |||
| c.argument('include_path', include_path_type) | |||
| c.argument('recursive', recursive_type) | |||
| c.argument('content_type', arg_group='Additional Flags', help="Specify content type of the file. " | |||
| "If unspecified, imply no-guess-mime-type.") | |||
There was a problem hiding this comment.
According to https://docs.microsoft.com/en-us/azure/storage/common/storage-ref-azcopy-copy#options
Suggested change
| "If unspecified, imply no-guess-mime-type.") | |
| "If unspecified, imply --no-guess-mime-type.") |
jiasli
approved these changes
Mar 23, 2020
zhoxing-ms
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
Fix #6466
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.