Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Misc} wrap issue templates hint messages. #12600

Merged
merged 2 commits into from
Mar 19, 2020
Merged

{Misc} wrap issue templates hint messages. #12600

merged 2 commits into from
Mar 19, 2020

Conversation

yungezz
Copy link
Member

@yungezz yungezz commented Mar 16, 2020

History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)

[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yungezz yungezz added this to the S167 milestone Mar 16, 2020
@yungezz yungezz requested review from qwordy and fengzhou-msft March 16, 2020 10:26
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 16, 2020

issue templates

@qwordy
Copy link
Member

qwordy commented Mar 17, 2020

What's purpose of this PR? Why comment these explanations?

@yungezz
Copy link
Member Author

yungezz commented Mar 17, 2020

What's purpose of this PR? Why comment these explanations?

today, the hint messages mixed with real issue input from creator. wrap those hint messages up so that issue creator could still see them when creating issues, why it will not be showed after rendering in broswer.

@qwordy
Copy link
Member

qwordy commented Mar 18, 2020

What's purpose of this PR? Why comment these explanations?

today, the hint messages mixed with real issue input from creator. wrap those hint messages up so that issue creator could still see them when creating issues, why it will not be showed after rendering in broswer.

They all disappear in preview page:
https://github.com/Azure/azure-cli/blob/f39f4bf94078577561cf9c930e6e7d1072438db7/.github/ISSUE_TEMPLATE/Bug_report.md

@yungezz
Copy link
Member Author

yungezz commented Mar 18, 2020

What's purpose of this PR? Why comment these explanations?

today, the hint messages mixed with real issue input from creator. wrap those hint messages up so that issue creator could still see them when creating issues, why it will not be showed after rendering in broswer.

They all disappear in preview page:
https://github.com/Azure/azure-cli/blob/f39f4bf94078577561cf9c930e6e7d1072438db7/.github/ISSUE_TEMPLATE/Bug_report.md

that's the purpose, so issue reader could see only real messages about the issue. when creating a new issue, those messages are still there. I can close the PR if people like those hints message in issue :)

@yungezz yungezz merged commit 182dc42 into Azure:dev Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants