[Compute] disk create: add --disk-iops-read-only, --disk-mbps-read-only, --max-shares, --image-reference, --image-reference-lun, --gallery-image-reference, --gallery-image-reference-lun #12618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwordy
requested review from
arrownj,
fengzhou-msft,
haroldrandom,
jiasli,
Juliehzl and
qianwens
as code owners
jiasli
approved these changes
Mar 18, 2020
|
No YAML re-recording? |
in progress |
yungezz
reviewed
Mar 23, 2020
| @@ -127,7 +127,7 @@ def default_api_version(self): | |||
| ResourceType.MGMT_NETWORK: '2019-11-01', | |||
| ResourceType.MGMT_COMPUTE: SDKProfile('2019-07-01', { | |||
| 'resource_skus': '2019-04-01', | |||
| 'disks': '2019-07-01', | |||
| 'disks': '2019-11-01', | |||
There was a problem hiding this comment.
have we done full regression :)
There was a problem hiding this comment.
Done. Can't guarantee no error in live test. But no new error in disk related tests.
| c.argument('max_shares', type=int, help='The maximum number of VMs that can attach to the disk at the same time. Value greater than one indicates a disk that can be mounted on multiple VMs at the same time') | ||
| c.argument('disk_iops_read_only', type=int, help='The total number of IOPS that will be allowed across all VMs mounting the shared disk as ReadOnly. One operation can transfer between 4k and 256k bytes') | ||
| c.argument('disk_mbps_read_only', type=int, help='The total throughput (MBps) that will be allowed across all VMs mounting the shared disk as ReadOnly. MBps means millions of bytes per second - MB here uses the ISO notation, of powers of 10') | ||
| c.argument('image_reference', help='ID of the image from which to create a disk') |
There was a problem hiding this comment.
OK. Plan to support ID, name, URN
There was a problem hiding this comment.
Support ID and URN now. Name (custom image) is not support by service.
yungezz
added
Compute
arrownj
approved these changes
Mar 30, 2020
yungezz
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12380
Changes:
--disk-iops-read-only
The total number of IOPS that will be allowed across all VMs mounting the shared disk as ReadOnly. One operation can transfer between 4k and 256k bytes
--disk-mbps-read-only
The total throughput (MBps) that will be allowed across all VMs mounting the shared disk as ReadOnly. MBps means millions of bytes per second - MB here uses the ISO notation, of powers of 10
--image-reference
ID or URN (publisher:offer:sku:version) of the image from which to create a disk
--image-reference-lun
If the disk is created from an image's data disk, this is an index that indicates which of the data disks in the image to use. For OS disks, this field is null
--gallery-image-reference
ID of the shared galley image version from which to create a disk
--gallery-image-reference-lun
If the disk is created from an image's data disk, this is an index that indicates which of the data disks in the image to use. For OS disks, this field is null
--max-shares
The maximum number of VMs that can attach to the disk at the same time. Value greater than one indicates a disk that can be mounted on multiple VMs at the same time
Examples:
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Compute] upgrade disk API version to 2019-11-01
[Compute] disk create: add --disk-iops-read-only, --disk-mbps-read-only, --max-shares, --image-reference, --image-reference-lun, --gallery-image-reference, --gallery-image-reference-lun
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.