Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] az storage blob generate-sas: Fix#11643 to support encoding blob url #12632

Merged
merged 2 commits into from
Mar 20, 2020

Conversation

Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented Mar 18, 2020

History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)

[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.


Fix issue #11643

This checklist is used to make sure that common guidelines for a pull request are followed.

@Juliehzl Juliehzl requested a review from qianwens as a code owner March 18, 2020 07:07
@Juliehzl Juliehzl requested a review from zhoxing-ms March 18, 2020 07:07
@Juliehzl Juliehzl self-assigned this Mar 18, 2020
Copy link
Member

@qianwens qianwens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Juliehzl Juliehzl merged commit cdad270 into Azure:dev Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants