{AKS} Add UDR capabilities #12644
Merged
{AKS} Add UDR capabilities #12644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @fengzhou-msft could you pls help to review? thanks. |
yungezz
suggested changes
Mar 20, 2020
| @@ -260,6 +260,10 @@ | |||
| type: int | |||
| short-summary: Load balancer idle timeout in minutes. | |||
| long-summary: Desired idle timeout for load balancer outbound flows, default is 30 minutes. Please specify a value in the range of [4, 120]. | |||
| - name: --outbound-type | |||
There was a problem hiding this comment.
there's a PR in extension repo revert the behavior, could you pls sync: Azure/azure-cli-extensions#1405? @gtracer
There was a problem hiding this comment.
@yungezz I own both PRs.
In extension, outbound-type is already enabled. That PR just removes one piece of validation (network-plugin) and adds a vnetsubnet-id validation. No core behavior is being reverted. Please let me know what you think is specifically being reverted
There was a problem hiding this comment.
@yungezz following up as I need to merge this PR before the cutoff for the release
yungezz
approved these changes
Mar 26, 2020
gtracer
force-pushed
the
gt/port_udr_from_cli_extension
branch
from
e0893f6 to
8eeca12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.