[ACR] Add a validator for argument 'registry_name' #12685
Conversation
| """Omit login server endpoint suffix.""" | ||
| registry = namespace.registry_name | ||
| if registry: | ||
| suffix = cmd.cli_ctx.cloud.suffixes.acr_login_server_endpoint |
There was a problem hiding this comment.
seems not all clouds define the acr_login_server_endpoint(AzureGermanCloud), it's better to have an empty check here.
There was a problem hiding this comment.
Thanks for the comment! How about suffixes? Are there any documentation I can refer?
There was a problem hiding this comment.
AzureGermanCloud is defined here,
. You can also find the other default clouds definition in the same file.There was a problem hiding this comment.
It's very helpful, thanks a lot!
|
HI @Wwwsylvia just fyi, next azure CLI release CC date is 3/25 UTC +8, pls help to address comments and let us know when the PR ready for reviewing/merging. |
Noted, thanks! |
ghost
added
Resolve #12631
Add a validator for argument 'registry_name' to omit login server endpoint suffix.
The validator applies to all
az acrcommands, exceptaz acr createandaz acr check-name.Behavior
(specify registry name with --registry)
(specify login server with --registry)
(specify login server with --name)
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.