[Packaging] drop support for python 3.5 #12694
Conversation
fengzhou-msft
requested review from
arrownj,
bim-msft,
haroldrandom,
jiasli,
Juliehzl,
mmyyrroonn and
qianwens
as code owners
|
drop python 3.5 |
|
hi @fengzhou-msft why knack drop 3.5 support? what's impact to users if stopping support 3.5? |
|
knack relies on mock 4.0 which dropped python 3.5. This impacts users using pip install with python 3.5. Telemetry shows the rate for python 3.5 in the past week is less than 0.5%. |
| @@ -154,9 +153,6 @@ | |||
| with open('HISTORY.rst', 'r', encoding='utf-8') as f: | |||
| HISTORY = f.read() | |||
|
|
|||
| if sys.version_info < (3, 4): | |||
There was a problem hiding this comment.
Why just remove this statement instead of changing it to if sys.version_info < (3, 6)?
There was a problem hiding this comment.
This check was added in this PR. Adding this sets the hard limit for python versions at installation and block lower verisons. When we remove a version from the classifier, we're droppiong support for that version. It doesn't mean the code must not be compatible with that version. We can remove python 3.6 simply becaused it reaches end-of-life in the future, but our CLI code could still be totally compatible with python 3.6 at that time until at one point it's not. We will not fix it as we stated it's not supported.
There was a problem hiding this comment.
@fengzhou-msft I think I got your point, thanks for the clarification.
knack 0.7.0rc1 has dropped support for python 3.5.
Resolve #12525
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.