[Compute] az vmss set-orchestration-service-state: support vmss set orchestration service state #12756
Conversation
| short-summary: Change ServiceState property for a given service within a VMSS. | ||
| examples: | ||
| - name: Change ServiceState property for AutomaticRepairs | ||
| text: az vmss set-orchestration-service-state --service-name AutomaticRepairs --action Resume --name MyScaleSet --resource-group MyResourceGroup |
There was a problem hiding this comment.
how to get the state? This will impact command name, will it be orchestration-service-state set or set-orchestration-service-state
There was a problem hiding this comment.
As I know, currently there is only one set operation for it. The result of this operation will show in the instance view. We can use az vmss get-instance-view -g rg -n vmss_name to get the orchestration services state. This is also another request they asked in the email. It is also supported in this PR.
There was a problem hiding this comment.
thanks for clarification. As long as there will no command on show/list etc, the command should be ok. Another question, I remembered that automatic instance repair command is preview, what's status of this command?
There was a problem hiding this comment.
we have already remove the Preview tag as they asked for this before.
There was a problem hiding this comment.
yes. should we mark this as preview also?
There was a problem hiding this comment.
I will send an email to get their confirmation first.
There was a problem hiding this comment.
confirmed not to add Preview tag.
| @@ -595,6 +596,10 @@ def load_arguments(self, _): | |||
|
|
|||
| with self.argument_context('vmss nic list') as c: | |||
| c.argument('virtual_machine_scale_set_name', arg_type=vmss_name_type, options_list=['--vmss-name'], id_part=None) | |||
|
|
|||
| with self.argument_context('vmss set-orchestration-service-state') as c: | |||
| c.argument('service_name', arg_type=get_enum_type(OrchestrationServiceNames), help='The name of the service.') | |||
There was a problem hiding this comment.
the name of the orchestration service
| @@ -179,7 +179,8 @@ def load_command_table(self, _): | |||
|
|
|||
| compute_disk_encryption_set_sdk = CliCommandType( | |||
| operations_tmpl='azure.mgmt.compute.operations#DiskEncryptionSetsOperations.{}', | |||
| client_factory=cf_disk_encryption_set | |||
| client_factory=cf_disk_encryption_set, | |||
| operation_group='disk_encryption_sets' | |||
There was a problem hiding this comment.
typo? added disk_encryption_sets group?
There was a problem hiding this comment.
good find. forgot to remove it.
| self.check('vmss.automaticRepairsPolicy.gracePeriod', 'PT30M') | ||
| ]) | ||
| self.cmd('vmss set-orchestration-service-state -g {rg} -n {vmss} --service-name {service_name} --action Resume') | ||
| self.cmd('vmss set-orchestration-service-state -g {rg} -n {vmss} --service-name {service_name} --action Suspend') |
There was a problem hiding this comment.
will add this part.
arrownj
requested review from
haroldrandom,
jiasli,
Juliehzl and
qianwens
as code owners
| @@ -71,7 +71,7 @@ | |||
| 'azure-mgmt-botservice~=0.2.0', | |||
| 'azure-mgmt-cdn==4.1.0rc1', | |||
| 'azure-mgmt-cognitiveservices~=5.0.0', | |||
| 'azure-mgmt-compute~=11.0', | |||
| 'azure-mgmt-compute~=12.0', | |||
There was a problem hiding this comment.
thanks for the full live test regression. @qwordy +1 for live test framework
There was a problem hiding this comment.
I'm running the full live test for VM in my local. And hope there will be no new failure.
Description of PR (Mandatory)
(Why this PR? What is changed? What is the effect? etc. A high-quality description can accelerate the review process)
Testing Guide
(Example commands with explanations)
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.