Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{RDBMS} Updating tests, help, params file #12776

Merged
merged 4 commits into from
Apr 1, 2020
Merged

{RDBMS} Updating tests, help, params file #12776

merged 4 commits into from
Apr 1, 2020

Conversation

ramnov
Copy link
Contributor

@ramnov ramnov commented Mar 28, 2020

Description of PR (Mandatory)

  1. Updating tests to obtain private endpoint connection information from server show command instead of az rest
  2. Updating help file with proper indentation
  3. Updating params file with proper description of public network access

Testing Guide
(Example commands with explanations)

History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)

[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan yonzhan requested review from qianwens and zhoxing-ms March 28, 2020 01:40
@yonzhan yonzhan added this to the S168 milestone Mar 28, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 28, 2020

add to S168

@ramnov
Copy link
Contributor Author

ramnov commented Mar 30, 2020

@Juliehzl : please help in reviewing/merging

Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Juliehzl Juliehzl merged commit 67d9164 into Azure:dev Apr 1, 2020
@Juliehzl Juliehzl changed the title [RDBMS] Updating tests, help, params file {RDBMS} Updating tests, help, params file Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants