{Monitor}Bug fix for stop iteration #12800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Juliehzl @arrownj @haroldrandom Is there any better way to fix it? I mean more native in python. |
src/azure-cli/azure/cli/command_modules/monitor/operations/autoscale_settings.py
Outdated
Show resolved
Hide resolved
| profile_names = [x.name for x in autoscale_settings.profiles] | ||
| if not profile_name in profile_names: | ||
| from knack.util import CLIError | ||
| raise CLIError('Profile name is invalid. Please check the existence of the profile.') | ||
| profile = next(x for x in autoscale_settings.profiles if x.name == profile_name) |
There was a problem hiding this comment.
Another alternative is to use try...except sinppet to catch StopIteration error, then raise CLIError.
There was a problem hiding this comment.
well. So next cannot handle such scenario and we need extra logic. Right? Compared to try..except, I prefer current one.
There was a problem hiding this comment.
using try..except is the same what you did now.
arrownj
reviewed
Mar 31, 2020
src/azure-cli/azure/cli/command_modules/monitor/tests/latest/test_monitor_autoscale.py
Outdated
Show resolved
Hide resolved
added 2 commits
March 31, 2020 14:34
mmyyrroonn
force-pushed
the
fix-12191-sutoscale-rules
branch
from
62f81ca to
82400f4
Compare
arrownj
approved these changes
Mar 31, 2020
haroldrandom
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12191
Description of PR (Mandatory)
(Why this PR? What is changed? What is the effect? etc. A high-quality description can accelerate the review process)
Testing Guide
(Example commands with explanations)
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.