Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install page with workaround for requests bug #1362

Merged
merged 2 commits into from
Nov 18, 2016

Conversation

derekbekoe
Copy link
Member

Add temporary note for workaround for #1360.

@mayurid
Copy link
Member

mayurid commented Nov 18, 2016

:shipit:

@tjprescott
Copy link
Member

Why add this to our README? If it temporary why not keep the local issue until requests is fixed? I doubt people will dig through the README before posting an issue anyways (though they MIGHT see the issue is already in our list and refer to that).

@@ -55,6 +55,9 @@ Enable tab completion with ``source az.completion.sh``.

Some prerequisites may be required. See our `Preview Install Guide <https://github.com/Azure/azure-cli/blob/master/doc/preview_install_guide.md>`__.

If you run into an ``AttributeError: 'X509' object has no attribute '_x509'`` error, downgrade your version of the requests library from 2.12.1 to 2.11.1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make it sense to put it under a new section called workaround to make it more visible, since almost every installation will hit this issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@derekbekoe
Copy link
Member Author

@tjprescott Going to go ahead and merge to provide some visibility through the README (for those that read it).
Once it's resolved, we can remove.

@derekbekoe derekbekoe merged commit fca6a8f into Azure:master Nov 18, 2016
@derekbekoe derekbekoe deleted the tmp-requests-msg branch November 18, 2016 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants