Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Profile} Show tenant display_name for tenants without subscriptions #16206

Merged
merged 3 commits into from
Dec 18, 2020

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Dec 9, 2020

Description
#12726, #12824 used a workaround to retrieve the missing display_name from additional_properties['displayName'].

After Azure/azure-rest-api-specs#8384 is merged and azure-mgmt-resource SDK is regenerated, this line is now (on the contrary) discarding display_name because additional_properties always exists and display_name will be overwritten with None.

Testing Guide

> az login
...
The following tenants don't contain accessible subscriptions. Use 'az login --allow-no-subscriptions' to have tenant level access.
246b1785-9030-40d8-a0f0-d94b15dc002c 'Selfhost'
ca97aaa0-5a12-4ae3-8929-c8fb57dd93d6 'jlcorp'

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 9, 2020

Profile

@yonzhan yonzhan added this to the S180 milestone Dec 9, 2020
@jiasli jiasli merged commit 2d27b9f into Azure:dev Dec 18, 2020
@jiasli jiasli deleted the display-name branch December 18, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants