Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Hotfix: Install OpenSSL 3.0 in the docker image #24839

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Dec 8, 2022

Description

An out-of-courtesy fix for #24836

openssl command was replaced by openssl1.1 in the docker image by #24768.

Some users using Azure CLI docker image directly rely on openssl command without explicitly specifying openssl dependency. This is not a good practice as a dependency(Azure CLI)'s dependency (openssl) is an internal implementation, so the user shouldn't assume the dependency's dependency is always available.

Even though we don't guarantee the availability of tools or packages in the docker image, we add openssl out of courtesy, so that those users can be unblocked quickly without changing their code.

Additional information

This hotfix will only be rolled out to the docker image. We won't bump version or forward main branch because

  • this is not a change on Azure CLI
  • this will make az upgrade on all platforms think there is an available update

@jiasli jiasli requested a review from bebound December 8, 2022 09:06
@ghost ghost requested review from wangzelin007, yonzhan and kairu-ms December 8, 2022 09:06
@ghost ghost added the Auto-Assign Auto assign by bot label Dec 8, 2022
@ghost ghost assigned jiasli Dec 8, 2022
@ghost ghost added this to the Dec 2022 (2023-01-03) milestone Dec 8, 2022
@ghost ghost added the Packaging label Dec 8, 2022
@jiasli jiasli removed the request for review from kairu-ms December 8, 2022 09:06
@ghost ghost added the Installation label Dec 8, 2022
@ghost ghost requested a review from jsntcy December 8, 2022 09:06
@jiasli
Copy link
Member Author

jiasli commented Dec 8, 2022

Even though openssl is small, it still contributes to docker image size making it bigger: #7387 (comment), :

# apk info openssl
openssl-3.0.7-r0 description:
Toolkit for Transport Layer Security (TLS)

openssl-3.0.7-r0 webpage:
https://www.openssl.org/

openssl-3.0.7-r0 installed size:
868 KiB

@wangzelin007
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jiasli jiasli marked this pull request as ready for review December 9, 2022 05:55
@jiasli jiasli merged commit 85bb41c into Azure:release Dec 9, 2022
@jiasli jiasli deleted the openssl branch December 9, 2022 06:30
avgale pushed a commit to avgale/azure-cli that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants