{Compute} az sig image-version create: Change --virtual-machine parameter map to new VM backend field
#28627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @Jing-song, |
️✔️AzureCLI-BreakingChangeTest
|
|
Compute |
microsoft-github-policy-service
bot
requested review from
yonzhan,
zhoxing-ms and
yanzhudd
microsoft-github-policy-service
bot
added
the
Compute
Jing-song
changed the title
az sig image-version create: Change managed-image parameter map to new VM backend fieldaz sig image-version create: Change --virtual-machine parameter map to new VM backend field
|
@ReaNAiveD Could you please help review this PR? |
ReaNAiveD
reviewed
Mar 26, 2024
Comment on lines
4783
to
4786
| if managed_image is not None: | ||
| source = GalleryArtifactVersionFullSource(id=managed_image) | ||
| if virtual_machine is not None: | ||
| source = GalleryArtifactVersionFullSource(virtual_machine_id=virtual_machine) |
There was a problem hiding this comment.
Accord to the L2425-L2434 in file vm/_validators.py, the virtual_machine value is also assigned to managed_image. Consequently, the line source = GalleryArtifactVersionFullSource(id=managed_image) will be executed even when a --virtual-machine argument is provided. This overlap could introduce potential risks.
ReaNAiveD
reviewed
Mar 26, 2024
| @@ -4782,6 +4782,8 @@ def create_image_version(cmd, resource_group_name, gallery_name, gallery_image_n | |||
| source = os_disk_image = data_disk_images = None | |||
| if managed_image is not None: | |||
| source = GalleryArtifactVersionFullSource(id=managed_image) | |||
| if virtual_machine is not None: | |||
There was a problem hiding this comment.
The issue mentioned the min API version is 2023-07-03. Should we wrap the code with min_api check?
ReaNAiveD
approved these changes
Mar 26, 2024
zhoxing-ms
approved these changes
Mar 26, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
changed the title
az sig image-version create: Change --virtual-machine parameter map to new VM backend fieldaz sig image-version create: Change --virtual-machine parameter map to new VM backend field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sig image-version createDescription
close #28488
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.