-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{CI} Fix Codegen Coverage #30413
{CI} Fix Codegen Coverage #30413
Conversation
️✔️AzureCLI-FullTest
|
Hi @wangzelin007, |
️✔️AzureCLI-BreakingChangeTest
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Looks good as a workaround. This task has bad design. It should not install all extensions in the same env and expects every extension works fine. We'll likely encounter another dependency conflict in the future. |
We need to install all extensions to calculate code generation coverage. |
I feel the reliable way is to install, calculate and then uninstall each extension modules one by one and finally sum up the whole result from extension modules. |
Related command
Due to the inconsistent versions of jinja2 required by aosm and alias, and the random order of extension installations, installing a lower version of jinja2 can result in the following error:
Therefore, i want to enforce the use of a higher version of jinja2 for codegen coverage.
![image](https://private-user-images.githubusercontent.com/18628534/390752905-eae483df-c035-4426-a6b6-8a9f1c81634b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4MDA2MzcsIm5iZiI6MTczODgwMDMzNywicGF0aCI6Ii8xODYyODUzNC8zOTA3NTI5MDUtZWFlNDgzZGYtYzAzNS00NDI2LWE2YjYtOGE5ZjFjODE2MzRiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDAwMDUzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE5YTJhZDE1YjM3ZDRlZjQwNzdjNTMzYTI0ODI5YWU4ZjlmY2IyMGZlMmJkNzQ2YjM5NmJmZWJhZDhiOTQ1ZDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.wMBMI0sRxXAIWnuhia78pgWrg43_2eewCeSd1vA6dqY)
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.