Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wait/no-wait support to "az disk" commands. #3390

Merged
merged 1 commit into from
May 19, 2017
Merged

Add wait/no-wait support to "az disk" commands. #3390

merged 1 commit into from
May 19, 2017

Conversation

tjprescott
Copy link
Member

Closes #2215. Partial addresses #1528.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • [N/A] Each new command has a test.

(see Authoring Command Modules)

@tjprescott tjprescott added Breaking Change Compute az vm/vmss/image/disk/snapshot labels May 17, 2017
@tjprescott tjprescott requested a review from yugangw-msft May 17, 2017 20:47
@codecov-io
Copy link

codecov-io commented May 17, 2017

Codecov Report

Merging #3390 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3390      +/-   ##
=========================================
- Coverage    70.7%   70.7%   -0.01%     
=========================================
  Files         393     393              
  Lines       25472   25474       +2     
  Branches     3884    3884              
=========================================
+ Hits        18010   18011       +1     
- Misses       6319    6320       +1     
  Partials     1143    1143
Impacted Files Coverage Δ
...azure-cli-vm/azure/cli/command_modules/vm/_help.py 100% <100%> (ø) ⬆️
...re-cli-vm/azure/cli/command_modules/vm/commands.py 89.59% <100%> (+0.06%) ⬆️
...zure-cli-vm/azure/cli/command_modules/vm/custom.py 73.36% <100%> (ø) ⬆️
...li-rdbms/azure/cli/command_modules/rdbms/custom.py 63.93% <0%> (-1.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0111833...e6899b3. Read the comment docs.

@yugangw-msft
Copy link
Contributor

LGTM. Let @johanste provides the query to verify we don't have many users using the disk delete. Once confirmed, please go ahead and merge

@tjprescott
Copy link
Member Author

@yugangw-msft after looking at the usage statistics, are you comfortable with the breaking change or should be hold off on adding the prompt?

@tjprescott tjprescott merged commit d264872 into Azure:master May 19, 2017
@tjprescott tjprescott deleted the WaitNoWaitDiskCommands branch May 19, 2017 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants