[DO NOT MERGE][ACR] Add support for network rules #7964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added MacOS example for generating SAS token with expiration time. The call to the date function `date -d` works on Linux, but not on MacOS. I provided MacOS sample.
Updated help text and test location for low priority vmss
…ion (Azure#7863) * authentication-type can be set to all to permit both ssh key and password authentication * Added tests and updated authentication type validation error. * Added history entry, bumped version. Checked out file recording from dev branch. * Addressed PEP8 issues. * Updated test_vm_defaults auth tests. * Updated other profile's unittests. * Now infers authentication_type, other updates. Do not need to explicitly pass all. * Updated help text. Fix conflict by checking out ephemeral os disk recording from dev branch. * Style changes.
* Properly handle parsing of ids from -o tsv on windows. * Removed unused import.
…se. (Azure#7869) * changed api-version in recordings and set to new ver of sdk * version bump and history * fix immutability test * re-record all * fixed recordings fix recording * bumped version after release
* reenable extension checking in CI minor edit to get travis to run edit * minor edit
* support key-id description * linter error fixes * consolidate * use official sdk * update history
…zure#7941) * BotService: fix tests, mprove test robustness and update recordings * BotService; fixing tests * BotService: Update recordings
djyou
changed the title
|
PR contains SDK under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7256
Fixes AzureCR#297
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.