PR comment

Azure · Feb 25, 2023 · 3a68151 · 3a68151
1 parent b058432
commit 3a68151
Show file tree

Hide file tree

Showing 12 changed files with 49 additions and 97 deletions.
diff --git a/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs b/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs
@@ -46,10 +46,8 @@ public static void WriteTrace(
 
                 if (isRootTrace)
                 {
-                    writer.WriteFieldName("start date");
-                    writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.DateFormatString));
-                    writer.WriteFieldName("start time");
-                    writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.HourTimeFormatString));
+                    writer.WriteFieldName("start datetime");
+                    writer.WriteStringValue(trace.StartTime.ToString(TraceWriter.DateTimeFormatString));
                 }
                 writer.WriteFieldName("duration in milliseconds");
                 writer.WriteNumber64Value(trace.Duration.TotalMilliseconds);

diff --git a/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceTextWriter.cs b/Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceTextWriter.cs
@@ -18,7 +18,7 @@ namespace Microsoft.Azure.Cosmos.Tracing
     internal static partial class TraceWriter
     {
         internal static readonly string HourTimeFormatString = "HH:mm:ss:fff";
-        internal static readonly string DateFormatString = "yyyy-MM-dd";
+        internal static readonly string DateTimeFormatString = "yyyy-MM-ddTHH:mm:ss.fffZ";
 
         private static class TraceTextWriter
         {

diff --git a/...Tests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml b/...Tests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BatchOperationsAsync.xml
@@ -61,8 +61,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "ExecuteAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

diff --git a/...rTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BulkOperationsAsync.xml b/...rTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.BulkOperationsAsync.xml
@@ -60,8 +60,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -219,8 +218,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -378,8 +376,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -537,8 +534,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -696,8 +692,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -855,8 +850,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1014,8 +1008,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1173,8 +1166,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1332,8 +1324,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1491,8 +1482,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1806,8 +1796,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

diff --git a/...latorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ChangeFeedAsync.xml b/...latorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ChangeFeedAsync.xml
@@ -238,8 +238,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1125,8 +1124,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1740,8 +1738,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -2343,8 +2340,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -2892,8 +2888,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {

diff --git a/...torTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.MiscellanousAsync.xml b/...torTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.MiscellanousAsync.xml
@@ -44,8 +44,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateDatabaseAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -155,8 +154,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateDatabaseAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

diff --git a/...lineTest/TestBaseline/EndToEndTraceWriterBaselineTests.PointOperationsExceptionsAsync.xml b/...lineTest/TestBaseline/EndToEndTraceWriterBaselineTests.PointOperationsExceptionsAsync.xml
@@ -68,8 +68,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -255,8 +254,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -516,8 +514,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -753,8 +750,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1033,8 +1029,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"
@@ -1272,8 +1267,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "CreateItemAsync",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "data": {
     "Client Configuration": "Redacted To Not Change The Baselines From Run To Run"

diff --git a/...s.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.QueryAsync.xml b/...s.EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.QueryAsync.xml
@@ -163,8 +163,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -754,8 +753,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1358,8 +1356,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1950,8 +1947,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -2581,8 +2577,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -3232,8 +3227,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -3833,8 +3827,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {

diff --git a/...mulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ReadFeedAsync.xml b/...mulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ReadFeedAsync.xml
@@ -139,8 +139,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -692,8 +691,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1258,8 +1256,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {
@@ -1812,8 +1809,7 @@
       <Json><![CDATA[{
   "Summary": {},
   "name": "Trace Forest",
-  "start date": "0001-01-01",
-  "start time": "00:00:00:000",
+  "start datetime": "0001-01-01T00:00:00Z",
   "duration in milliseconds": 0,
   "children": [
     {