Batch API: Add support of request options for transactional batch #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakesh Kumar <[email protected]>
rakkuma
requested review from
bchong95,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
Signed-off-by: Rakesh Kumar <[email protected]>
ealsur
reviewed
May 28, 2020
Signed-off-by: Rakesh Kumar <[email protected]>
ealsur
previously approved these changes
Jun 22, 2020
kirankumarkolli
previously approved these changes
Jul 2, 2020
|
@j82w can you please take a look? |
Signed-off-by: Rakesh Kumar <[email protected]>
abhijitpai
reviewed
Jul 8, 2020
abhijitpai
reviewed
Jul 8, 2020
j82w
approved these changes
Jul 10, 2020
kirankumarkolli
approved these changes
Jul 14, 2020
|
Its looking great thanks @rakkuma |
abhijitpai
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for user to pass request options for a transactional batch request.
This will enable request level features and restricts specific set of valid option for batch request.
Session token is not added in the option because batch won't honor it. It is only applicable for read requests and since batch can have write request, it is not sent to backend.
Also in TransactionalBatchResponse we were keeping separate fields for ActivityId, RequestCharge and RetryAfter. Now we will keep the whole Header like in ItemResponse.cs. This will enable user to get SessionToken out of batch response options. This won't effect user as external callable function will be same. It's just internally how we are keeping values.
Type of change