Internal Query : Fix Remove Antlr dependency for now #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchong95
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
reviewed
Jun 16, 2020
sboshra
approved these changes
Jun 17, 2020
kirankumarkolli
pushed a commit
that referenced
this pull request
Jul 11, 2020
* backing out Antlr dependancy for now * removed check for zero query plan calls
sboshra
pushed a commit
that referenced
this pull request
Aug 13, 2020
…ndows x64 systems (#1743) * Revert "Internal Query : Fix Remove Antlr dependency for now (#1626)" This reverts commit ed7faae. * added test for antlr dependancy Co-authored-by: j82w <[email protected]>
sboshra
pushed a commit
that referenced
this pull request
Aug 13, 2020
sboshra
pushed a commit
that referenced
this pull request
Aug 21, 2020
sboshra
pushed a commit
that referenced
this pull request
Aug 21, 2020
* Revert "Internal Query : Fix Remove Antlr dependency for now (#1626)" This reverts commit ed7faae. * added test for antlr dependancy * added monadic parser * Added test cases * fixed * merged ... * updated antlr files * added baselines for scalar expressions * renamed to match" * added order by baselines * added offset limit clause baselines * added where clause baseline * added from clause baselines * added select clause baselines * added group by baselines * resolved iteration comments
sboshra
pushed a commit
that referenced
this pull request
Oct 7, 2020
* rename * drafted out abstract classes * drafted out basic in memory collection * got basic crud test working * implemented split and readfeed * switching tracks to try asyncenumerable * started playing with async enumerator * added full IAsyncEnumerable interface * made the single partition range enumerator more plug and play * got in memory partition range enumerator working * cleaned up code * got cross partition working * resolved iteration comments * started this query integration work, but need to make minor edits * made the continuation token part of the page * added 429 tests * refactored tests to have more common code * added an empty page test * added basic query support * made code templatized * drafted all parallel query enumerator * got aggregates working * got skip working * adding take stage * added distinct * got group by working * got the pipeline working * wired through query stages * started parallel cpq debugging * not putting back finished enumerators * need to stop using feedrange * moved to pkrange instead of feed range * fixed baseline * got basic cases working * got continuation token support working * simplified query draining with continuation token path * resolved iteration comment by adding DocumentContainer as an abstraction layer * stopped returning 429 for get partition key ranges, since there isn't anything for us to do * updated tests * added document container interface * added end to end tests * got basic query working end to end * composition over inheritance * started order by, but need the first PR to go through. To many merge conflicts * fix build errors * need to make serious changes for order by * Revert "Internal Query : Fix Remove Antlr dependency for now (#1626)" This reverts commit ed7faae. * added test for antlr dependancy * need to wire up the item enumerator to order by * need to refactor for failures inside of the filter logic * drafted out a solution without splits and continuation token * got basic order by working * need to get the parser involved for this one * added monadic parser * whoops * hooked up parser and offline engine to the inmemorycontainer * got continuation token support working * moved around some files * removed old execution component code * moved continuation tokens around * got basic order by working end to end * need to handle splits * got split working for order by * refactored to be a state machine * fixed bug where partiton key ranges where matched to a continuation due to string.Empty start and ends * added parallel buffering * resolved iteration comments * fixed some non baseline tests * updated baselines * honoring ranges and compressed continuation tokens for parallel * wired through cancellation token * fixed random integration bugs * fixed some test cases * fixed test * fixed page size bugs with group by * removed unused collections * opting for simple resource id: * fixed bug with JOINs + ORDER BY + Continuation tokens * left some comments * fixed bugs * added split tests for parallel and patched bugs in the inmemorycontainer * fixed more tests * setting feed iterator flag for non retriable exception * apparently we don't actually handle name cache is stale exceptions * dummy commit Co-authored-by: j82w <[email protected]>
sboshra
pushed a commit
that referenced
this pull request
Oct 13, 2020
* rename * drafted out abstract classes * drafted out basic in memory collection * got basic crud test working * implemented split and readfeed * switching tracks to try asyncenumerable * started playing with async enumerator * added full IAsyncEnumerable interface * made the single partition range enumerator more plug and play * got in memory partition range enumerator working * cleaned up code * got cross partition working * resolved iteration comments * started this query integration work, but need to make minor edits * made the continuation token part of the page * added 429 tests * refactored tests to have more common code * added an empty page test * added basic query support * made code templatized * drafted all parallel query enumerator * got aggregates working * got skip working * adding take stage * added distinct * got group by working * got the pipeline working * wired through query stages * started parallel cpq debugging * not putting back finished enumerators * need to stop using feedrange * moved to pkrange instead of feed range * fixed baseline * got basic cases working * got continuation token support working * simplified query draining with continuation token path * resolved iteration comment by adding DocumentContainer as an abstraction layer * stopped returning 429 for get partition key ranges, since there isn't anything for us to do * updated tests * added document container interface * added end to end tests * got basic query working end to end * composition over inheritance * started order by, but need the first PR to go through. To many merge conflicts * fix build errors * need to make serious changes for order by * Revert "Internal Query : Fix Remove Antlr dependency for now (#1626)" This reverts commit ed7faae. * added test for antlr dependancy * need to wire up the item enumerator to order by * need to refactor for failures inside of the filter logic * drafted out a solution without splits and continuation token * got basic order by working * need to get the parser involved for this one * added monadic parser * whoops * hooked up parser and offline engine to the inmemorycontainer * got continuation token support working * moved around some files * removed old execution component code * moved continuation tokens around * got basic order by working end to end * need to handle splits * got split working for order by * refactored to be a state machine * fixed bug where partiton key ranges where matched to a continuation due to string.Empty start and ends * added parallel buffering * resolved iteration comments * fixed some non baseline tests * updated baselines * honoring ranges and compressed continuation tokens for parallel * wired through cancellation token * fixed random integration bugs * fixed some test cases * fixed test * fixed page size bugs with group by * removed unused collections * opting for simple resource id: * fixed bug with JOINs + ORDER BY + Continuation tokens * left some comments * fixed bugs * added split tests for parallel and patched bugs in the inmemorycontainer * fixed more tests * setting feed iterator flag for non retriable exception * apparently we don't actually handle name cache is stale exceptions * added in memory changefeed test simulator * wip * wip * drafted out cross partition change feed enumerator code * got basic change feed enumeration cases working * added changefeed enumeration tests * moved over to cosmos element based continuation token * added change feed tests * nuking directory * nuking feed ranges directory * removed more change feed code * fixed NRE * fixed min vs max inclusive * fixed partition key wiring for queries * fixed miscellaneous bugs * resolved iteration comments * removed try catch throw
sboshra
pushed a commit
that referenced
this pull request
Oct 20, 2020
* rename * drafted out abstract classes * drafted out basic in memory collection * got basic crud test working * implemented split and readfeed * switching tracks to try asyncenumerable * started playing with async enumerator * added full IAsyncEnumerable interface * made the single partition range enumerator more plug and play * got in memory partition range enumerator working * cleaned up code * got cross partition working * resolved iteration comments * started this query integration work, but need to make minor edits * made the continuation token part of the page * added 429 tests * refactored tests to have more common code * added an empty page test * added basic query support * made code templatized * drafted all parallel query enumerator * got aggregates working * got skip working * adding take stage * added distinct * got group by working * got the pipeline working * wired through query stages * started parallel cpq debugging * not putting back finished enumerators * need to stop using feedrange * moved to pkrange instead of feed range * fixed baseline * got basic cases working * got continuation token support working * simplified query draining with continuation token path * resolved iteration comment by adding DocumentContainer as an abstraction layer * stopped returning 429 for get partition key ranges, since there isn't anything for us to do * updated tests * added document container interface * added end to end tests * got basic query working end to end * composition over inheritance * started order by, but need the first PR to go through. To many merge conflicts * fix build errors * need to make serious changes for order by * Revert "Internal Query : Fix Remove Antlr dependency for now (#1626)" This reverts commit ed7faae. * added test for antlr dependancy * need to wire up the item enumerator to order by * need to refactor for failures inside of the filter logic * drafted out a solution without splits and continuation token * got basic order by working * need to get the parser involved for this one * added monadic parser * whoops * hooked up parser and offline engine to the inmemorycontainer * got continuation token support working * moved around some files * removed old execution component code * moved continuation tokens around * got basic order by working end to end * need to handle splits * got split working for order by * refactored to be a state machine * fixed bug where partiton key ranges where matched to a continuation due to string.Empty start and ends * added parallel buffering * resolved iteration comments * fixed some non baseline tests * updated baselines * honoring ranges and compressed continuation tokens for parallel * wired through cancellation token * fixed random integration bugs * fixed some test cases * fixed test * fixed page size bugs with group by * removed unused collections * opting for simple resource id: * fixed bug with JOINs + ORDER BY + Continuation tokens * left some comments * fixed bugs * added split tests for parallel and patched bugs in the inmemorycontainer * fixed more tests * setting feed iterator flag for non retriable exception * apparently we don't actually handle name cache is stale exceptions * added in memory changefeed test simulator * wip * wip * drafted out cross partition change feed enumerator code * got basic change feed enumeration cases working * added changefeed enumeration tests * moved over to cosmos element based continuation token * added change feed tests * dont know if this will pan out * fixed various test cases * resolved iteration comments * fixed build error * added versioning and rid check * fixed some tests * fixed some tests * updated contracts * added unit tests for continuation token serialization
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Query : Fix Remove Antlr dependency for now
Removing this dependency until we figure things out.