[Internal] Performance: Fixes exception serialization when tracing is not enabled #1999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an Exception travels through the
ResourceThrottleRetryPolicy.ShouldRetry
, and the error is not one the current policy handles, we trace it like so:DefaultTrace.TraceError has this signature:
So the object[]
ToString
invocation on each of the arguments is only called if tracing is enabled.But our current code on
this.GetExceptionMessage
callsexception.ToString()
so it is serializing the exception even if tracing is not enabled (because it needs to construct the object array).This PR defers the ToString call to only be invoked if there is tracing enabled.