Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LINQ : Adds User Defined Function Translation Support #2206

Merged
merged 15 commits into from
Feb 11, 2021
Merged

LINQ : Adds User Defined Function Translation Support #2206

merged 15 commits into from
Feb 11, 2021

Conversation

dpiessens
Copy link
Contributor

@dpiessens dpiessens commented Feb 9, 2021 •
edited
Loading

Description

Turns on UDF translation support for LINQ. Continuation of PR #1526

IQueryable<Book> queryable = client
        .GetContainer("database", "container")
        .GetItemLinqQueryable<Book>()
        .Where(b => CosmosLinq.InvokeUserDefinedFunction("toLowerCase", b.Title) == "war and peace");

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Closing issues

closes: #993

@j82w
Copy link
Contributor

j82w commented Feb 9, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dpiessens
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 2206 in repo Azure/azure-cosmos-dotnet-v3

@j82w
Copy link
Contributor

j82w commented Feb 9, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

j82w
j82w previously approved these changes Feb 10, 2021
View reviewed changes
@j82w
Copy link
Contributor

j82w commented Feb 10, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@j82w j82w changed the title LINQ : Add UDF Translation Support 2 LINQ : Adds User Defined Function Translation Support Feb 10, 2021
@khdang
Copy link
Member

khdang commented Feb 10, 2021

Thanks @dpiessens for making this change.

khdang
khdang previously approved these changes Feb 10, 2021
View reviewed changes
sboshra
sboshra previously approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dpiessens
Copy link
Contributor Author

Can you approve and re-run builds? Looks like the docs changed needed the API json to be updated.

@j82w
Copy link
Contributor

j82w commented Feb 10, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

j82w
j82w previously approved these changes Feb 10, 2021
View reviewed changes
@j82w
Copy link
Contributor

j82w commented Feb 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@j82w
Copy link
Contributor

j82w commented Feb 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

j82w
j82w previously approved these changes Feb 11, 2021
View reviewed changes
@dpiessens dpiessens dismissed stale reviews from kirankumarkolli and j82w via 5e7d826 February 11, 2021 14:08
@j82w
Copy link
Contributor

j82w commented Feb 11, 2021

/azp run

j82w
j82w previously approved these changes Feb 11, 2021
View reviewed changes
@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@j82w
Copy link
Contributor

j82w commented Feb 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@j82w j82w merged commit dae2747 into Azure:master Feb 11, 2021
This was referenced Mar 8, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealsur ealsur ealsur left review comments

@j82w j82w j82w approved these changes

@sboshra sboshra sboshra left review comments

@khdang khdang khdang left review comments

@kirankumarkolli kirankumarkolli kirankumarkolli left review comments

@bchong95 bchong95 Awaiting requested review from bchong95

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees
No one assigned
Labels
API_REVIEW LINQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: Is there a way to invoke an UDF?
7 participants
@dpiessens @j82w @khdang @ealsur @kirankumarkolli @sboshra @bchong95