CosmosClientBuilder: Adds overload for passing TokenCredential #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levimatheri
requested review from
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
|
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@levimatheri please run https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/UpdateContracts.ps1 on your branch to generate the changes in the API surface. You can execute it in a PS shell at the root of the repo's clone and it should update a JSON file that exists, which you can include in the PR. |
ealsur
changed the title
Fixes the status code description to match the value.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ealsur
approved these changes
Sep 28, 2021
kirankumarkolli
approved these changes
Sep 28, 2021
|
Thanks @levimatheri for your contribution! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds constructor to
CosmosClientBuilderfor using aTokenCredentialinstance, e.g.DefaultAzureCredential.Type of change
Please delete options that are not relevant.
Closing issues
Closes #2749