Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] API Version: Updates DefaultAPIVersion to v2019_10_14 to indicate merge support #3015

Conversation

ramarag
Copy link
Contributor

@ramarag ramarag commented Feb 4, 2022

Pull Request Template

Description

Changing the API version to v2019_10_14, any version greater than or equal to this will indicate to cosmos db that SDK is capable of handling partition merge. We plan to block sdks that do not have support when partitionmerge feature will be turned on in the service.

Type of change

Please delete options that are not relevant.

  • [] New feature (non-breaking change which adds functionality)

Closing issues

To automatically close an issue: closes #IssueNumber

@ramarag ramarag force-pushed the users/ramarag/changeApiVersionToIndicateMergeSupport branch from bddcf05 to 56a6d2a Compare February 4, 2022 06:54
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address matias comment

@ealsur
Copy link
Member

ealsur commented Feb 9, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@ealsur ealsur changed the title Update DeaultAPIVersion to v2019_10_14 to indicate merge support [Internal] API Version: Updates DefaultAPIVersion to v2019_10_14 to indicate merge support Feb 9, 2022
@ealsur ealsur enabled auto-merge (squash) February 9, 2022 21:59
@ealsur ealsur merged commit 83d4d0c into Azure:master Feb 9, 2022
ramarag added a commit to ramarag/azure-cosmos-dotnet-v3 that referenced this pull request Mar 22, 2022
…_14 to indicate merge support (Azure#3015)"

This reverts commit 83d4d0c.
ealsur pushed a commit that referenced this pull request Mar 24, 2022
…SDK has merge (#3111)

* Revert "[Internal] API Version: Updates DefaultAPIVersion to v2019_10_14 to indicate merge support (#3015)"

This reverts commit 83d4d0c.

* [PartitionMerge] Add SDKSupportedCapabilities to hint that SDK has merge support

* caching the header value and adding tests

Co-authored-by: j82w <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants