Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Adds aggressive prefetching for GROUP BY and COUNT(DISTINCT) #3380

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Query: Adds aggressive prefetching for GROUP BY and COUNT(DISTINCT) #3380

merged 2 commits into from
Aug 31, 2022

Conversation

neildsh
Copy link
Contributor

@neildsh neildsh commented Aug 10, 2022 •
edited
Loading

Description

Previously, we had enabled aggressive prefetching for scalar aggregates. This change enables it for GROUP BY and COUNT(DISTINCT)

@neildsh
Copy link
Contributor Author

neildsh commented Aug 10, 2022

/azp run

2 similar comments
@neildsh
Copy link
Contributor Author

neildsh commented Aug 11, 2022

/azp run

@neildsh
Copy link
Contributor Author

neildsh commented Aug 17, 2022

/azp run

sboshra
sboshra previously approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

neildsh added 2 commits August 31, 2022 13:30
@neildsh
Enable aggressive prefetching for dcount
82c6e2e 
Clean up AggressivePrefetchPipelineTests a little to follow continuations on the base container

retrigger checks
@neildsh
Add aggressive prefetching for GROUP BY
370f239
@neildsh neildsh force-pushed the users/ndeshpan/dcountPrefetch branch from d4b7c9e to 370f239 Compare August 31, 2022 21:58
@neildsh neildsh changed the title [Internal] Query: Adds aggressive prefetching for COUNT(DISTINCT) [Internal] Query: Adds aggressive prefetching for GROUP BY and COUNT(DISTINCT) Aug 31, 2022
@neildsh neildsh changed the title [Internal] Query: Adds aggressive prefetching for GROUP BY and COUNT(DISTINCT) Query: Adds aggressive prefetching for GROUP BY and COUNT(DISTINCT) Aug 31, 2022
@ealsur ealsur enabled auto-merge (squash) August 31, 2022 22:48
sboshra
sboshra approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ealsur ealsur merged commit 5589885 into master Aug 31, 2022
@ealsur ealsur deleted the users/ndeshpan/dcountPrefetch branch August 31, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sboshra sboshra sboshra approved these changes

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@adityasa adityasa Awaiting requested review from adityasa adityasa is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@ealsur ealsur Awaiting requested review from ealsur

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neildsh @sboshra @ealsur