Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GatewayAddressCache: Fixes Unobserved Exception During Background Address Refresh #4039

Merged
merged 7 commits into from
Aug 16, 2023
Merged

GatewayAddressCache: Fixes Unobserved Exception During Background Address Refresh #4039

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7e71753
Code changes to fix unobserved exception during background address re…
kundadebdatta Aug 15, 2023
c49ed81
Code changes to add exception handler in task.
kundadebdatta Aug 16, 2023
83f90d5
Code changes to fix null ref exception.
kundadebdatta Aug 16, 2023
f8e6c59
Revert "Code changes to fix null ref exception."
kundadebdatta Aug 16, 2023
29faa46
Revert "Code changes to add exception handler in task."
kundadebdatta Aug 16, 2023
d2b9f6b
Code changes to address review comments.
kundadebdatta Aug 16, 2023
b45cd95
Revert "Code changes to address review comments."
kundadebdatta Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions Microsoft.Azure.Cosmos/src/Routing/GatewayAddressCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,14 +302,27 @@ public async Task<PartitionAddressInformation> TryGetAddressesAsync(
.ReplicaTransportAddressUris
.Any(x => x.ShouldRefreshHealthStatus()))
{
Task refreshAddressesInBackgroundTask = Task.Run(async () => await this.serverPartitionAddressCache.RefreshAsync(
key: partitionKeyRangeIdentity,
singleValueInitFunc: (currentCachedValue) => this.GetAddressesForRangeIdAsync(
request,
cachedAddresses: currentCachedValue,
Task refreshAddressesInBackgroundTask = Task.Run(async () =>
kundadebdatta marked this conversation as resolved.
Show resolved Hide resolved
{
try
{
await this.serverPartitionAddressCache.RefreshAsync(
key: partitionKeyRangeIdentity,
singleValueInitFunc: (currentCachedValue) => this.GetAddressesForRangeIdAsync(
request,
cachedAddresses: currentCachedValue,
partitionKeyRangeIdentity.CollectionRid,
partitionKeyRangeIdentity.PartitionKeyRangeId,
forceRefresh: true));
}
catch (Exception ex)
{
DefaultTrace.TraceWarning("Failed to refresh addresses in the background for the collection rid: {0} with exception: {1}. '{2}'",
kundadebdatta marked this conversation as resolved.
Show resolved Hide resolved
partitionKeyRangeIdentity.CollectionRid,
partitionKeyRangeIdentity.PartitionKeyRangeId,
forceRefresh: true)));
ex,
System.Diagnostics.Trace.CorrelationManager.ActivityId);
}
});
}

return addresses;
Expand Down