-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Refactors Optimistic Direct Execution to be turned on by default on .NET SDK #4225
Query: Refactors Optimistic Direct Execution to be turned on by default on .NET SDK #4225
Conversation
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/SanityQueryTests.cs
Outdated
Show resolved
Hide resolved
…om/Azure/azure-cosmos-dotnet-v3 into users/akotalwar/TurnOnODEByDefault
…om/Azure/azure-cosmos-dotnet-v3 into users/akotalwar/TurnOnODEByDefault
….Tests/BaselineTest/TestBaseline/PartitionKeyHashBaselineTest.Lists.xml
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqTestsCommon.cs
Outdated
Show resolved
Hide resolved
I think we should maximize the "default" behavior testing. I would be tempted to reduce the number of tests that switch off ODE explicitly in this change. |
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Query/Pipeline/FullPipelineTests.cs
Show resolved
Hide resolved
Please assert that the correct document is returned... the return value is just being thrown away here #Resolved Refers to: Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosMultiHashTest.cs:474 in ab69838. [](commit_id = ab69838, deletion_comment = False) |
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosMultiHashTest.cs
Outdated
Show resolved
Hide resolved
This would result in loss of coverage for the regular pipelines. Perhaps it would be preferable to run the tests with ODE enabled as well as disabled? In reply to: 1880222410 |
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqTestsCommon.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqTestsCommon.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqTestsCommon.cs
Outdated
Show resolved
Hide resolved
...Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Linq/LinqTranslationBaselineTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/SanityQueryTests.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Query/Pipeline/FullPipelineTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…om/Azure/azure-cosmos-dotnet-v3 into users/akotalwar/TurnOnODEByDefault
…om/Azure/azure-cosmos-dotnet-v3 into users/akotalwar/TurnOnODEByDefault
…om/Azure/azure-cosmos-dotnet-v3 into users/akotalwar/TurnOnODEByDefault
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Template
Description
Refactors Optimistic Direct Execution to be turned on by default on .NET SDK. With this change, all single partition queries will use the Optimistic Direct Execution pipeline unless specified otherwise.
Nature of the breaking change:
This change makes uses of a new type of continuation token in the SDK that not all previous version of SDK support.
As a result, when a query invoked using newer SDK version (containing this change) is invoked, the continuation token produced may not be accepted by the previous version of SDK for query continuation purposes.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber