Azurecore: Fixes upgrading azure core dependency to latest #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kirankumarkolli
changed the title
kirankumarkolli
changed the title
kirankumarkolli
requested review from
kirillg,
FabianMeiswinkel,
khdang,
sboshra,
adityasa,
neildsh and
Pilchie
as code owners
kirankumarkolli
changed the title
kirankumarkolli
changed the title
kirankumarkolli
changed the title
Pilchie
approved these changes
Oct 18, 2024
NaluTripician
approved these changes
Oct 18, 2024
|
Just curious: What are benefits we are getting with this upgrade? and did we evaluate "breaking changes" because here we are making big jump (from 19 to 44 version)? |
It's a minor version upgrade (not major). Benefits
|
kirankumarkolli
changed the title
kirankumarkolli
changed the title
kirankumarkolli
changed the title
kirankumarkolli
changed the title
kirankumarkolli
changed the title
This was referenced Oct 19, 2024
sourabh1007
pushed a commit
that referenced
this pull request
Oct 22, 2024
Azure.Core: Fixed upgrading azure core dependency to 1.44.1 Changes - ResourceType: Conflict between Azure.Core and Microsoft.Azure.Cosmos.Documents - Microsoft.Bcl.AsyncInterfaces: Azure.Core needs at-least 6.0.0 (as Azure core upgraded part of minor version, we are good as well) - Microsoft.Azure.Cosmos.Encryption.Custom: Direct dependency on Azure.Core removed (now its transitive) - Microsoft.Azure.Cosmos.Encryption.Custom.Performance.Tests: `NU1903` added Newtonsoft.Json dependency - Performance project: `NU1903` Newtonsoft dependency upgraded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure.Core: Fixed upgrading azure core dependency to 1.44.1
Changes
NU1903added Newtonsoft.Json dependencyNU1903Newtonsoft dependency upgraded