-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Client encryption]: Drops RentArrayBufferWriter #4847
Open
JanHyka
wants to merge
100
commits into
Azure:master
Choose a base branch
from
juraj-blazek:users/jan-hyka/drop_rentarraybufferwriter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−270
Open
Changes from all commits
Commits
Show all changes
100 commits
Select commit
Hold shift + click to select a range
d6f89ea
Add baseline benchmarks for `Microsoft.Azure.Cosmos.Encryption.Custom`
juraj-blazek 8928b88
Cleanup
juraj-blazek 9dc7d54
Use set of static test data for benchmarks
juraj-blazek 368dc25
Merge branch 'master' into users/juraj-blazek/encryption-benchmark-ba…
juraj-blazek 38a198a
Add non-allocating APIs to encryptors
juraj-blazek e0bb8bf
WIP
juraj-blazek 9c3c276
Revert solution update
juraj-blazek c37a092
Merge branch 'users/juraj-blazek/encryption-benchmark-baseline' of ht…
juraj-blazek f4db1c6
Merge branch 'master' into users/juraj-blazek/encryption-benchmark-ba…
juraj-blazek 91714f9
Merge branch 'master' into users/juraj-blazek/encryption-benchmark-ba…
juraj-blazek 2058f8b
Merge remote-tracking branch 'origin/master' into users/juraj-blazek/…
juraj-blazek f33538c
Add implementation, fix tests
juraj-blazek 6923fd2
Switch to randomized encryption for benchmarks
juraj-blazek 4ea8690
Merge branch 'master' into users/juraj-blazek/encryption-benchmark-ba…
kr-santosh 03ef682
Some more array pooling
juraj-blazek 1044a89
Streaming deserialization
juraj-blazek f1db54d
Merge remote-tracking branch 'origin/master' into users/juraj-blazek/…
juraj-blazek 05bfc50
Cleanup
juraj-blazek 5629f74
Update MDE and rerun benchmarks
juraj-blazek 495d2c4
Add non-allocating APIs to encryptors
juraj-blazek b3f74b1
Merge branch 'master' into users/juraj-blazek/non-allocating-encryptor
14bce37
~ drop repeated DEK calls
4ff1601
! typo
d8a345c
~ update benchmark
03c06e0
~ fix tests
a1025c4
Merge branch 'Azure:master' into users/juraj-blazek/non-allocating-en…
JanHyka 3bf77c8
~ cleanup
ceaa8b5
+ refresh benchmark
611b3ac
+ unit test
9ca89d4
~ merge predecessor PR
8a78fe8
~ merge fixes and initial cleanup
8ed2135
~ write directly to output document instead of copying
bbe9845
! tests
a107f62
~ retrieve DataEncryptionKey only once per document
a1ad02b
! fix tests
4f2f072
~ update Aes algorithm to reuse GetEncryptedByteCount
cbbeee2
~ refactor EncryptionProcessor
b6c851c
! names
72ccae7
~ less static
8ea5879
Merge branch 'master' into users/juraj-blazek/encryption-array-pooling
8c60e69
Merge branch 'master' into users/juraj-blazek/encryption-array-pooling
5554aa0
~ merge fixes
28620ed
~ cleanup
eb059c8
~ unwanted changes
cc2eab5
- unused method
c9ba300
~ updates (PR)
9f9cbca
~ add stable vs preview release duplicity
c347e71
Merge branch 'users/juraj-blazek/encryption-array-pooling' into users…
64172b8
~ cleanup and parent branch merge
ff583f9
Merge branch 'master' into users/jan-hyka/refactor-encryption-processor
0ba8c34
Merge branch 'master' into users/jan-hyka/refactor-encryption-processor
326b1be
~ master merges
c520e16
- duplicate
5c40821
~ cleanup
99c7a75
+ Add .NET8.0 target for Cosmos.Encryption.Custom
31c20e7
- remove implicit IsPreview from csproj
90b2cec
+ JsonNodeSqlSerializer
6f27d9d
+ initial commit
d7c06d6
! EncryptioProperties System.Text.Json annotations
cb9d166
+ bump benchmark
5fc5165
~ wip
c9e7f30
+ initial for JsonNode decryption
9215f67
~ Merge branch 'master' into users/jan-hyka/jsonnode_serializer
fed6a3a
~ polishing and benchmark refresh
38cc928
- remove explicit System.Text.Json 8.0.5
ba4f73b
Merge branch 'users/jan-hyka/jsonnode_serializer' into users/jan-hyka…
424028c
Merge branch 'master' into users/jan-hyka/jsonnode_encryptionProcessor
2af9ddb
~ propagate changes from master
30c18d0
Merge branch 'users/jan-hyka/jsonnode_encryptionProcessor' into users…
54b0ad9
~ fixes for preview x non-preview branching
69c8978
Merge branch 'master' into users/jan-hyka/jsonnode_encryptionProcessor
JanHyka ad15ceb
+ tests
a0ccd44
Merge branch 'master' into users/jan-hyka/jsonnode_encryptionProcessor
d9c315d
~ complete merge from master & update benchmark
b11db28
Merge branch 'users/jan-hyka/jsonnode_encryptionProcessor' into users…
996252b
+ initial
758e98d
+ tests, fixes and benchmark
420a35d
! bugfix
d08be05
~ benchmark update
0bf29b8
+ cleanup
2b2209f
+ stream serializer
f03c92d
Merge branch 'master' into users/jan-hyka/stream_deserializer
42462d5
~ preview branching fixes
703830f
+ add support for Stream deserialization of obsoleted encryption algo…
4319524
~ final touches
940d667
Merge branch 'master' into users/jan-hyka/stream_deserializer
fa0020c
~ PR based changes
8e45769
Merge branch 'master' into users/jan-hyka/stream_deserializer
kirankumarkolli c98f2bf
- drop JsonNode serializer/deserializer
3be6843
+ rms
de555a8
- drop rentArrayBufferWriter
428f2e1
Merge branch 'master' into users/jan-hyka/drop_jsonnode
8ce3622
~ fix the mess after merge
10ad1d4
~ fix merge mess
81394b2
- drop JsonNode based benchmarks
a439cf2
Merge branch 'users/jan-hyka/drop_jsonnode' into users/jan-hyka/drop_…
b4da46c
- drop files we don't need yet
98adb5c
Merge branch 'master' into users/jan-hyka/drop_rentarraybufferwriter
kirankumarkolli ff5a844
~ reference RecyclableMemoryStream 3.0.1 package instead
JanHyka 8a20aa1
Merge branch 'master' into users/jan-hyka/drop_rentarraybufferwriter
juraj-blazek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
211 changes: 0 additions & 211 deletions
211
Microsoft.Azure.Cosmos.Encryption.Custom/src/RentArrayBufferWriter.cs
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RecyclableMemoryStream is outside of Azure core has allowed list of dependencies.
One options is to inline the code as Jan has before.
https://azure.github.io/azure-sdk/dotnet_introduction.html#dotnet-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see where that requirement comes from... to avoid dependency hell. The question is whether avoiding one evil doesn't invite much greater one instead:
I am not saying referencing some random 3rd party library would be a good idea, otoh entirely blacklisting pretty much everything including Microsoft.* doesn't seem neither safe nor future proof either. Might be worth consideration.