Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom User Assigned Identities against Aspire Projects #3634

Closed
wants to merge 2 commits into from

Conversation

rudiv
Copy link

@rudiv rudiv commented Apr 2, 2024

See dotnet/aspire#3339 for more information.

This change adds support to azd to consume a new userAssignedIdentities property in the Aspire manifest.

An example being:

"userAssignedIdentities": [
  {
    "clientId": "00000000-0000-0000-0000-000000000000",
    "resourceId": "/subscriptions/\u003Csubscription_id\u003E/resourcegroups/my-rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/my-user",
    "env": "TEST"
  },
  {
    "clientId": "{identities.outputs.clientId}",
    "resourceId": "{identities.outputs.resourceId}",
    "env": "TEST2"
  }
]

The change adds support for:

  1. Detection of template strings within this new property
  2. The generation of environment variables to support the Client IDs
  3. The addition of the userAssignedIdentities in the container's yaml

Copy link
Contributor

Thank you for your contribution rudiv! We will review the pull request and get back to you soon.

@rudiv rudiv force-pushed the aspire-project-uai branch from 0a59a00 to 865afcd Compare April 13, 2024 17:30
@ellismg
Copy link
Member

ellismg commented Apr 22, 2024

I'm going to close this for now - based on the discussion in dotnet/aspire#3339 we do want to support this scenario long term, but we don't think this is the right way to do it (and it likely is something we'll want to do post GA once we move the logic for created the IAC for Container Apps into the Aspire deployment package and outside of azd.

@ellismg ellismg closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported identify a customer issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants