Fixing --enableAuth param when tested locally (#4211)

* fixing enableAuth param * adding tests for enableAuth * Consolidating tests * trying out change to exclude dotnetZip vulnerability * trying to parse out dontetzip * changing where object * changing check vulnerabilities back
Azure · Jan 7, 2025 · 208362c · 208362c
1 parent 6f1f4ad
commit 208362c
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 1 deletion.
diff --git a/src/Azure.Functions.Cli/Actions/HostActions/Startup.cs b/src/Azure.Functions.Cli/Actions/HostActions/Startup.cs
@@ -74,7 +74,11 @@ public IServiceProvider ConfigureServices(IServiceCollection services)
                     .AddScheme<ArmAuthenticationOptions, CliAuthenticationHandler<ArmAuthenticationOptions>>(ArmAuthenticationDefaults.AuthenticationScheme, _ => { });
             }
 
-            services.AddSingleton<IAuthorizationHandler, CoreToolsAuthorizationHandler>();
+            // Only set up authorization handler which bypasses all local auth if enableAuth param is not set 
+            if (!_enableAuth)
+            {
+                services.AddSingleton<IAuthorizationHandler, CoreToolsAuthorizationHandler>();
+            }
 
             services.AddWebJobsScriptHostAuthorization();
 

diff --git a/test/Azure.Functions.Cli.Tests/E2E/StartTests.cs b/test/Azure.Functions.Cli.Tests/E2E/StartTests.cs
@@ -392,6 +392,52 @@ await CliTester.Run(new RunConfiguration[]
             }, _output);
         }
 
+        [Theory]
+        [InlineData("function", false, "Welcome to Azure Functions!", "response from default function should be 'Welcome to Azure Functions!'", "Selected out-of-process host.")]
+        [InlineData("anonymous", true, "Welcome to Azure Functions!", "response from default function should be 'Welcome to Azure Functions!'", "Selected out-of-process host.")]
+        [InlineData("anonymous", true, "", "the call to the function is unauthorized", "\"status\": \"401\"")]
+        public async Task Start_DotnetIsolated_Test_EnableAuthFeature(string authLevel, bool enableAuth, string resultOfFunctionCall, string becauseResult, string testOutputHelperValue)
+        {
+            string templateCommand = $"new --template Httptrigger --name HttpTrigger --authlevel ${authLevel}";
+            string startCommand = enableAuth ? $"start --build --port {_funcHostPort} --verbose --enableAuth" : $"start --build --port {_funcHostPort} --verbose";
+            await CliTester.Run(new RunConfiguration[]
+            {
+                new RunConfiguration
+                {
+                    Commands = new[]
+                    {
+                        "init . --worker-runtime dotnet-isolated",
+                        templateCommand,
+                    },
+                },
+                new RunConfiguration
+                {
+                    Commands = new[]
+                    {
+                        startCommand,
+                    },
+                    ExpectExit = false,
+                    Test = async (workingDir, p, _) =>
+                    {
+                        using (var client = new HttpClient() { BaseAddress = new Uri($"http://localhost:{_funcHostPort}") })
+                        {
+                            (await WaitUntilReady(client)).Should().BeTrue(because: _serverNotReady);
+                            var response = await client.GetAsync("/api/HttpTrigger?name=Test");
+                            var result = await response.Content.ReadAsStringAsync();
+                            p.Kill();
+                            result.Should().Be(resultOfFunctionCall, because: becauseResult);
+
+                            if (_output is Xunit.Sdk.TestOutputHelper testOutputHelper)
+                            {
+                                testOutputHelper.Output.Should().Contain(testOutputHelperValue);
+                            }
+                        }
+                    },
+                    CommandTimeout = TimeSpan.FromSeconds(300)
+                }
+            }, _output);
+        }
+
         [Fact]
         public async Task Start_WithInspect_DebuggerIsStarted()
         {