Add orchestration query tests #3029
Open
+142
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgillum
approved these changes
Feb 4, 2025
| funcProcess.ErrorDataReceived += (sender, e) => logger.LogError(e?.Data); | ||
| funcProcess.OutputDataReceived += (sender, e) => logger.LogInformation(e?.Data); | ||
| funcProcess.ErrorDataReceived += (sender, e) => { try { logger.LogError(e?.Data); } catch (Exception) { Console.WriteLine("ERROR: Could not write error to test logger!"); Console.WriteLine(e?.Data); } }; | ||
| funcProcess.OutputDataReceived += (sender, e) => { try { logger.LogInformation(e?.Data); } catch (Exception) { Console.WriteLine("ERROR: Could not write information to test logger!"); Console.WriteLine(e?.Data); } } ; |
There was a problem hiding this comment.
If you want to make this more precise, just catch InvalidOperationException and do nothing - this is normal when the test process is shutting down.
| { | ||
| try | ||
| { | ||
| OrchestrationQuery filter = new OrchestrationQuery(Statuses: new List<OrchestrationRuntimeStatus> { OrchestrationRuntimeStatus.Running, OrchestrationRuntimeStatus.Pending, OrchestrationRuntimeStatus.Suspended }); |
There was a problem hiding this comment.
nit: wrap this into multiple lines. It's recommended to keep line lengths less than 120 chars or so.
Suggested change
| OrchestrationQuery filter = new OrchestrationQuery(Statuses: new List<OrchestrationRuntimeStatus> { OrchestrationRuntimeStatus.Running, OrchestrationRuntimeStatus.Pending, OrchestrationRuntimeStatus.Suspended }); | |
| OrchestrationQuery filter = new OrchestrationQuery(Statuses: new List<OrchestrationRuntimeStatus> | |
| { | |
| OrchestrationRuntimeStatus.Running, | |
| OrchestrationRuntimeStatus.Pending, | |
| OrchestrationRuntimeStatus.Suspended, | |
| }); |
| public static class OrchestrationQueryFunctions | ||
| { | ||
| [Function(nameof(GetAllStatus))] | ||
| public static async Task<HttpResponseData> GetAllStatus( |
There was a problem hiding this comment.
nit: Consider naming this GetAllInstances
| } | ||
|
|
||
| [Function(nameof(GetRunningStatus))] | ||
| public static async Task<HttpResponseData> GetRunningStatus( |
There was a problem hiding this comment.
nit: Consider naming this GetRunningInstances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for client.GetAllInstancesAsync() in dotnet-isolated
Pull request checklist
pending_docs.mdrelease_notes.md/src/Worker.Extensions.DurableTask/AssemblyInfo.csdevandmainbranches and will not be merged into thev2.xbranch.