Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundle/package process as fitting for an npm package #24

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented Sep 14, 2022

Fixes #23

See linked issue for background, but with that in mind we will now ship the following (modeled after existing azure sdk packages):

  1. A bundle of our code (dist/azure-functions.js)
  2. A minified bundle of our code (dist/azure-functions.min.js)
  3. Sources maps (*.js.map) and source code (*.ts) files for debugging purposes
old new
Screen Shot 2022-09-14 at 2 45 50 PM Screen Shot 2022-09-14 at 2 44 37 PM
411 KB 488 KB

This PR also combines the old build/lint commands to be run from within the webpack command. This reduces the number of commands we have to manually run and avoids problems if you forgot to run one. The downside is that the build may take longer - not terrible on my machine, but we will have to monitor this

I will cherry-pick this to v3.x after it is approved as it should apply to both.

@ejizba ejizba requested a review from hossam-nasr September 14, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants