-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: unique function name validation #236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallvictoria
requested review from
vrdmr,
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
August 6, 2024 19:57
hallvictoria
changed the title
fix: set functions_bindings to None
refactor: unique function name validation
Aug 6, 2024
gavin-aguiar
reviewed
Aug 6, 2024
gavin-aguiar
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change:
FunctionBuilder
object is at the function level.FunctionRegister
class is at the app level, so it is more suited for validation across the app as a whole.dict
is a property of theFunctionRegister
class. There is a new method added to theFunctionRegister
class for validating the function names. It loops through all the functions in the apps, adds the function name to thedict
, and throws an error if there's a repeat of function names. This validation method is added as part ofget_functions
so the non-distinct function name error is thrown in the same spot as it was previously.Extra change: