Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for multiple Set-Cookie response headers (native & wsgi/asgi) #1004

Merged
merged 25 commits into from
Jul 1, 2022

Conversation

YunchuWang
Copy link
Member

@YunchuWang YunchuWang commented Apr 11, 2022

Description

TODO:

  1. Add asgi/wsgi tests

Fixes Azure/azure-functions-python-library#107


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #1004 (e845986) into dev (1b52d72) will increase coverage by 0.55%.
The diff coverage is 96.25%.

@@            Coverage Diff             @@
##              dev    #1004      +/-   ##
==========================================
+ Coverage   83.46%   84.01%   +0.55%     
==========================================
  Files          33       34       +1     
  Lines        1778     1858      +80     
  Branches      282      299      +17     
==========================================
+ Hits         1484     1561      +77     
- Misses        230      232       +2     
- Partials       64       65       +1     
Flag Coverage Δ
unittests 84.01% <96.25%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/dispatcher.py 89.12% <ø> (ø)
azure_functions_worker/bindings/datumdef.py 72.22% <92.85%> (+8.49%) ⬆️
...e_functions_worker/bindings/nullable_converters.py 100.00% <100.00%> (ø)
azure_functions_worker/protos/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b52d72...e845986. Read the comment docs.

@YunchuWang YunchuWang force-pushed the wangbill/multi-cookie-resp-headers branch from ca0520c to 07e7621 Compare May 3, 2022 20:54
@vrdmr vrdmr changed the title Fix for GH#107: Enable support for multiple Set-Cookie response headers (native & wsgi/asgi) Enable support for multiple Set-Cookie response headers (native & wsgi/asgi) May 4, 2022
@YunchuWang YunchuWang force-pushed the wangbill/multi-cookie-resp-headers branch from 83e8d7c to 48c08d0 Compare May 6, 2022 00:19
@YunchuWang YunchuWang force-pushed the wangbill/multi-cookie-resp-headers branch from 1349e04 to fcafe6a Compare June 30, 2022 18:30
@YunchuWang YunchuWang merged commit c7a5236 into dev Jul 1, 2022
@YunchuWang YunchuWang deleted the wangbill/multi-cookie-resp-headers branch July 1, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python - azure.functions.WsgiMiddleware does not support multiple Set-Cookie response headers
2 participants