Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL Bindings end to end test #1026

Merged
merged 15 commits into from
Jul 28, 2022
Merged

Conversation

lucyzhang929
Copy link
Contributor

@lucyzhang929 lucyzhang929 commented May 10, 2022

Description

Add end to end test for SQL input and output bindings.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@YunchuWang YunchuWang force-pushed the luczhan/addsqlbindinge2etests branch from aaf2b2e to 2b445f5 Compare June 14, 2022 15:50
@lucyzhang929 lucyzhang929 changed the title add sql bindings e2e test Add SQL Bindings end to end test Jul 21, 2022
@lucyzhang929 lucyzhang929 marked this pull request as ready for review July 21, 2022 22:23
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1026 (4e52daf) into dev (068fbf8) will decrease coverage by 52.54%.
The diff coverage is n/a.

❗ Current head 4e52daf differs from pull request most recent head b2b4b84. Consider uploading reports for the commit b2b4b84 to get more accurate results

@@             Coverage Diff             @@
##              dev    #1026       +/-   ##
===========================================
- Coverage   84.01%   31.47%   -52.55%     
===========================================
  Files          34       34               
  Lines        1858     1846       -12     
  Branches      299      299               
===========================================
- Hits         1561      581      -980     
- Misses        232     1264     +1032     
+ Partials       65        1       -64     
Flag Coverage Δ
unittests 31.47% <ø> (-52.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e_functions_worker/bindings/nullable_converters.py 21.62% <0.00%> (-78.38%) ⬇️
azure_functions_worker/functions.py 23.72% <0.00%> (-72.32%) ⬇️
azure_functions_worker/dispatcher.py 19.20% <0.00%> (-69.93%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
azure_functions_worker/utils/dependency.py 32.57% <0.00%> (-60.61%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) ⬇️
azure_functions_worker/extension.py 43.92% <0.00%> (-55.16%) ⬇️
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-54.91%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 068fbf8...b2b4b84. Read the comment docs.

@gavin-aguiar
Copy link
Contributor

@lucyzhang929 The flake8 unit tests are failing. can you resolve them?

@gavin-aguiar gavin-aguiar merged commit 74aea84 into dev Jul 28, 2022
@gavin-aguiar gavin-aguiar deleted the luczhan/addsqlbindinge2etests branch July 28, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants