Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label flaky httpfunction tests in thirdparty pystein http tests #1060

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

YunchuWang
Copy link
Member

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1060 (b424067) into dev (98053f1) will decrease coverage by 51.23%.
The diff coverage is n/a.

❗ Current head b424067 differs from pull request most recent head 735964e. Consider uploading reports for the commit 735964e to get more accurate results

@@             Coverage Diff             @@
##              dev    #1060       +/-   ##
===========================================
- Coverage   83.09%   31.85%   -51.24%     
===========================================
  Files          33       33               
  Lines        1775     1764       -11     
  Branches      282      282               
===========================================
- Hits         1475      562      -913     
- Misses        232     1201      +969     
+ Partials       68        1       -67     
Flag Coverage Δ
unittests 31.85% <ø> (-51.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/functions.py 23.72% <0.00%> (-72.32%) ⬇️
azure_functions_worker/dispatcher.py 19.14% <0.00%> (-69.98%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) ⬇️
azure_functions_worker/extension.py 43.92% <0.00%> (-55.16%) ⬇️
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-54.91%) ⬇️
azure_functions_worker/utils/dependency.py 33.08% <0.00%> (-53.39%) ⬇️
azure_functions_worker/loader.py 32.14% <0.00%> (-52.39%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98053f1...735964e. Read the comment docs.

@YunchuWang YunchuWang changed the title lable flaky httpfunction tests in thirdparty pystein http tests label flaky httpfunction tests in thirdparty pystein http tests Jun 17, 2022
@YunchuWang YunchuWang marked this pull request as ready for review June 17, 2022 19:02
@YunchuWang YunchuWang merged commit c70c381 into dev Jun 17, 2022
@YunchuWang YunchuWang deleted the wangbill/mark-pystein-external-flaky-test branch June 17, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants