Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make logging lazy format #1067

Merged
merged 9 commits into from
Oct 19, 2022
Merged

make logging lazy format #1067

merged 9 commits into from
Oct 19, 2022

Conversation

YunchuWang
Copy link
Member

@YunchuWang YunchuWang commented Jun 27, 2022

Description

https://realpython.com/python-logging-source-code/#taking-advantage-of-lazy-formatting
https://blog.pilosus.org/posts/2020/01/24/python-f-strings-in-logging/

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #1067 (fe84ae6) into dev (9289105) will decrease coverage by 0.21%.
The diff coverage is 52.00%.

❗ Current head fe84ae6 differs from pull request most recent head fd8a4ce. Consider uploading reports for the commit fd8a4ce to get more accurate results

@@            Coverage Diff             @@
##              dev    #1067      +/-   ##
==========================================
- Coverage   85.09%   84.87%   -0.22%     
==========================================
  Files          33       33              
  Lines        1845     1845              
  Branches      273      273              
==========================================
- Hits         1570     1566       -4     
- Misses        205      208       +3     
- Partials       70       71       +1     
Flag Coverage Δ
unittests 84.87% <52.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/bindings/datumdef.py 72.22% <0.00%> (ø)
...ared_memory_data_transfer/file_accessor_windows.py 28.12% <ø> (ø)
...ared_memory_data_transfer/shared_memory_manager.py 78.35% <0.00%> (ø)
...s/shared_memory_data_transfer/shared_memory_map.py 83.92% <ø> (ø)
azure_functions_worker/extension.py 98.16% <ø> (ø)
.../shared_memory_data_transfer/file_accessor_unix.py 74.50% <36.36%> (ø)
azure_functions_worker/utils/dependency.py 86.46% <71.42%> (ø)
azure_functions_worker/dispatcher.py 88.15% <80.00%> (-1.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YunchuWang YunchuWang force-pushed the wangbill/lazy-format-logging branch from 1080ca9 to 5236a9f Compare June 30, 2022 19:40
@YunchuWang YunchuWang force-pushed the wangbill/lazy-format-logging branch from 5236a9f to 46cc4f2 Compare July 13, 2022 19:59
@YunchuWang YunchuWang marked this pull request as ready for review July 19, 2022 01:19
@YunchuWang YunchuWang force-pushed the wangbill/lazy-format-logging branch from 9d7c0fc to 1618e70 Compare October 14, 2022 18:32
@YunchuWang YunchuWang force-pushed the wangbill/lazy-format-logging branch from 1618e70 to a493594 Compare October 14, 2022 21:18
@vrdmr vrdmr merged commit 65d1bc6 into dev Oct 19, 2022
@vrdmr vrdmr deleted the wangbill/lazy-format-logging branch October 19, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants