Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tests utils #1109

Merged
merged 27 commits into from
Oct 24, 2022
Merged

Refactoring tests utils #1109

merged 27 commits into from
Oct 24, 2022

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Sep 30, 2022

Description

Key Changes:

  • Moved testutils and testutils_lc to tests/utils
  • Fixed linux consumption tests where the tests were not picking up the latest image version
  • Deleted tests/common dir. Its not used.
  • Pinned fastapi to 0.85.0. Latest release version has some bug.
  • Skipped SQL tests. TODO: unskip when library containing sql is released in test.pypi.
  • Skipped test_rpc_messages test: TODO: Flaky tests. Throwing module not found errors. Needs to be fixed.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #1109 (8af8143) into dev (e090dcc) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1109      +/-   ##
==========================================
+ Coverage   84.74%   84.97%   +0.22%     
==========================================
  Files          33       32       -1     
  Lines        1849     1817      -32     
  Branches      275      275              
==========================================
- Hits         1567     1544      -23     
+ Misses        210      203       -7     
+ Partials       72       70       -2     
Flag Coverage Δ
unittests 84.92% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/constants.py
azure_functions_worker/extension.py 99.08% <0.00%> (+0.91%) ⬆️
azure_functions_worker/logging.py 47.16% <0.00%> (+3.77%) ⬆️
azure_functions_worker/bindings/datumdef.py 72.22% <0.00%> (+4.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gavin-aguiar gavin-aguiar changed the title [WIP] Gaaguiar/move test utils Refactoring tests utils Oct 3, 2022
@gavin-aguiar gavin-aguiar marked this pull request as ready for review October 3, 2022 19:07
setup.py Outdated Show resolved Hide resolved
tests/common/ping/function.json Show resolved Hide resolved
tests/endtoend/test_linux_consumption.py Show resolved Hide resolved
tests/endtoend/test_sql_functions.py Outdated Show resolved Hide resolved
tests/unittests/test_http_functions.py Outdated Show resolved Hide resolved
tests/unittests/test_log_filtering_functions.py Outdated Show resolved Hide resolved
tests/utils/testutils.py Outdated Show resolved Hide resolved
tests/utils/testutils_lc.py Show resolved Hide resolved
tests/unittests/test_rpc_messages.py Outdated Show resolved Hide resolved
tests/utils/testutils_lc.py Outdated Show resolved Hide resolved
@gavin-aguiar gavin-aguiar merged commit 28e5fdb into dev Oct 24, 2022
@gavin-aguiar gavin-aguiar deleted the gaaguiar/move_test_utils branch October 24, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants