Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve indexing related logs #1112

Merged
merged 8 commits into from
Oct 6, 2022
Merged

Improve indexing related logs #1112

merged 8 commits into from
Oct 6, 2022

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Oct 5, 2022

Description

Added more debug logging for Pystein and module not found errors.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@gavin-aguiar gavin-aguiar marked this pull request as ready for review October 5, 2022 17:51
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #1112 (8f5b32a) into dev (7730062) will increase coverage by 1.15%.
The diff coverage is 92.30%.

❗ Current head 8f5b32a differs from pull request most recent head 2f41a0a. Consider uploading reports for the commit 2f41a0a to get more accurate results

@@            Coverage Diff             @@
##              dev    #1112      +/-   ##
==========================================
+ Coverage   83.88%   85.04%   +1.15%     
==========================================
  Files          34       33       -1     
  Lines        1868     1845      -23     
  Branches      300      273      -27     
==========================================
+ Hits         1567     1569       +2     
+ Misses        235      206      -29     
- Partials       66       70       +4     
Flag Coverage Δ
unittests 85.04% <92.30%> (+1.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/dispatcher.py 88.94% <80.00%> (-0.18%) ⬇️
azure_functions_worker/loader.py 85.05% <100.00%> (+0.53%) ⬆️
azure_functions_worker/utils/wrappers.py 100.00% <100.00%> (ø)
azure_functions_worker/utils/dependency.py 86.46% <0.00%> (-3.76%) ⬇️
azure_functions_worker/extension.py 98.16% <0.00%> (-0.92%) ⬇️
azure_functions_worker/main.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

azure_functions_worker/dispatcher.py Show resolved Hide resolved
azure_functions_worker/dispatcher.py Outdated Show resolved Hide resolved
azure_functions_worker/utils/wrappers.py Outdated Show resolved Hide resolved
azure_functions_worker/utils/wrappers.py Show resolved Hide resolved
@vrdmr vrdmr changed the title Added more debug logs Improve indexing related logs Oct 6, 2022
@vrdmr vrdmr merged commit 1cd47d8 into dev Oct 6, 2022
@vrdmr vrdmr deleted the gaaguiar/add_logging branch October 6, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants