Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e tests for PYTHON_THREADPOOL_THREAD_COUNT and FUNCTIONS_WORKER_PROCESS_COUNT #1136

Merged
merged 14 commits into from
Mar 15, 2023

Conversation

pdthummar
Copy link
Contributor

@pdthummar pdthummar commented Oct 27, 2022

Description

Adding e2e tests for PYTHON_THREADPOOL_THREAD_COUNT and FUNCTIONS_WORKER_PROCESS_COUNT.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #1136 (4c796fe) into dev (d844de5) will decrease coverage by 53.22%.
The diff coverage is n/a.

❗ Current head 4c796fe differs from pull request most recent head 73fc3db. Consider uploading reports for the commit 73fc3db to get more accurate results

@@             Coverage Diff             @@
##              dev    #1136       +/-   ##
===========================================
- Coverage   85.21%   32.00%   -53.22%     
===========================================
  Files          34       34               
  Lines        1900     1900               
  Branches      366      366               
===========================================
- Hits         1619      608     -1011     
- Misses        219     1291     +1072     
+ Partials       62        1       -61     
Flag Coverage Δ
unittests 32.00% <ø> (-53.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pdthummar pdthummar changed the title add e2e test for PYTHON_THREADPOOL_THREAD_COUNT. add e2e test for PYTHON_THREADPOOL_THREAD_COUNT and FUNCTIONS_WORKER_PROCESS_COUNT Oct 31, 2022
@pdthummar pdthummar changed the title add e2e test for PYTHON_THREADPOOL_THREAD_COUNT and FUNCTIONS_WORKER_PROCESS_COUNT add e2e tests for PYTHON_THREADPOOL_THREAD_COUNT and FUNCTIONS_WORKER_PROCESS_COUNT Oct 31, 2022
@pdthummar pdthummar merged commit a0a611f into dev Mar 15, 2023
@pdthummar pdthummar deleted the pthummar/add_features_e2e_tests branch March 15, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants