Added worker to pythonpath #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavin-aguiar
requested review from
vrdmr,
YunchuWang and
pdthummar
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #1215 +/- ##
===========================================
- Coverage 83.76% 32.00% -51.77%
===========================================
Files 34 34
Lines 1903 1903
Branches 366 366
===========================================
- Hits 1594 609 -985
- Misses 237 1293 +1056
+ Partials 72 1 -71
Flags with carried forward coverage won't be shown. Click here to find out more. |
vrdmr
approved these changes
Apr 14, 2023
| func_worker_dir = str(Path(__file__).absolute().parent) | ||
| env = os.environ | ||
|
|
||
| # Setting up python path for all environments to prioritize | ||
| # third-party user packages over worker packages in PYTHONPATH | ||
| user_pkg_paths = determine_user_pkg_paths() | ||
| joined_pkg_paths = os.pathsep.join(user_pkg_paths) | ||
| env['PYTHONPATH'] = f'{joined_pkg_paths}:{func_worker_dir}' | ||
| env['PYTHONPATH'] = f'{worker_path}:{joined_pkg_paths}:{func_worker_dir}' |
There was a problem hiding this comment.
Any way to add test for this? in the docker test as least?
gavin-aguiar
pushed a commit
that referenced
this pull request
May 5, 2023
This reverts commit a60ef25.
gavin-aguiar
pushed a commit
that referenced
this pull request
May 5, 2023
This reverts commit a60ef25.
5 tasks
gavin-aguiar
added a commit
that referenced
this pull request
May 8, 2023
gavin-aguiar
added a commit
that referenced
this pull request
Jun 7, 2023
* Revert "Added worker to pythonpath (#1215)" This reverts commit a60ef25. * Update Python SDK Version to 1.14.1b3 (#1232) * Update Python SDK Version to 1.14.1b3 * Update setup.py --------- Co-authored-by: AzureFunctionsPython <[email protected]> * Update Python Worker Version to 4.13.0 * Update Python Worker Version to 4.14.0 * Test fixes * Installing packages with -U * Install packages with updates * Adding python -m to pytest * Reverting change to codecov.yml --------- Co-authored-by: Gavin Aguiar <gavin@GavinPC> Co-authored-by: AzureFunctionsPython <[email protected]>
gavin-aguiar
added a commit
that referenced
this pull request
Jul 28, 2023
* Revert "Added worker to pythonpath (#1215)" This reverts commit a60ef25. * Update Python SDK Version to 1.14.1b3 (#1232) * Update Python SDK Version to 1.14.1b3 * Update setup.py --------- Co-authored-by: AzureFunctionsPython <[email protected]> * Update Python Worker Version to 4.13.0 * Update Python Worker Version to 4.14.0 * Importing azure functions in InitRequest by default * Updated tests --------- Co-authored-by: Gavin Aguiar <gavin@GavinPC> Co-authored-by: AzureFunctionsPython <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added worker to pythonpath
Description
Fixes #
PR information
Quality of Code and Contribution Guidelines