Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes: Upgrading pip to 23.0 #1221

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Build fixes: Upgrading pip to 23.0 #1221

merged 5 commits into from
Apr 27, 2023

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Apr 24, 2023

Description

DEPRECATION: azure-functions-worker is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at pypa/pip#8559

Fixes #1219


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1221 (b44d539) into dev (201c547) will decrease coverage by 51.98%.
The diff coverage is n/a.

❗ Current head b44d539 differs from pull request most recent head 957573e. Consider uploading reports for the commit 957573e to get more accurate results

@@             Coverage Diff             @@
##              dev    #1221       +/-   ##
===========================================
- Coverage   83.97%   32.00%   -51.98%     
===========================================
  Files          34       34               
  Lines        1903     1903               
  Branches      366      366               
===========================================
- Hits         1598      609      -989     
- Misses        234     1293     +1059     
+ Partials       71        1       -70     
Flag Coverage Δ
unittests 32.00% <ø> (-51.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/build_fixes branch from e5d598e to 64b5cdd Compare April 27, 2023 03:42
@gavin-aguiar gavin-aguiar changed the title [DNM] Build fixes Build fixes: Upgrading pip to 23.0 Apr 27, 2023
@gavin-aguiar gavin-aguiar marked this pull request as ready for review April 27, 2023 04:05
@gavin-aguiar gavin-aguiar merged commit 36efc47 into dev Apr 27, 2023
@gavin-aguiar gavin-aguiar deleted the gaaguiar/build_fixes branch April 27, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The pipeline to build the Python language worker is failing.
2 participants